Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reexport CrateName through nargo #6177

Merged
merged 1 commit into from
Sep 30, 2024
Merged

chore: reexport CrateName through nargo #6177

merged 1 commit into from
Sep 30, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Ideally nargo_cli would not need to directly hook into noirc_frontend but a number of imports it needs are not reexported by the packages which are supposed to be the entrypoints to the noir compiler (noirc_driver and nargo). This PR tackles a couple of cases of these issues.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from a team September 30, 2024 20:25
@TomAFrench TomAFrench added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit 1ac980b Sep 30, 2024
47 checks passed
@TomAFrench TomAFrench deleted the tf/export-cratename-from-nargo branch September 30, 2024 20:55
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Sep 30, 2024
@AztecBot
[1 changes] feat(perf): Remove redundant inc rc without instructions …
27d6427 
…between (noir-lang/noir#6183)

chore: reexport `CrateName` through `nargo` (noir-lang/noir#6177)
feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (noir-lang/noir#6168)
chore(docs): Add link to more info about proving backend to Solidity verifier page (noir-lang/noir#5754)
feat: let `Module::functions` and `Module::structs` return them in definition order (noir-lang/noir#6178)
chore: split `test_program`s into modules (noir-lang/noir#6101)
chore: remove `DefCollectorErrorKind::MacroError` (noir-lang/noir#6174)
feat(ssa): Simplify signed casts (noir-lang/noir#6166)
feat: visibility for modules (noir-lang/noir#6165)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Sep 30, 2024
@AztecBot
feat(perf): Remove redundant inc rc without instructions between (noi…
f9d7a14 
…r-lang/noir#6183)

chore: reexport `CrateName` through `nargo` (noir-lang/noir#6177)
feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (noir-lang/noir#6168)
chore(docs): Add link to more info about proving backend to Solidity verifier page (noir-lang/noir#5754)
feat: let `Module::functions` and `Module::structs` return them in definition order (noir-lang/noir#6178)
chore: split `test_program`s into modules (noir-lang/noir#6101)
chore: remove `DefCollectorErrorKind::MacroError` (noir-lang/noir#6174)
feat(ssa): Simplify signed casts (noir-lang/noir#6166)
feat: visibility for modules (noir-lang/noir#6165)
@AztecBot AztecBot mentioned this pull request Sep 30, 2024
Merged
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 1, 2024
@AztecBot
[1 changes] feat(perf): Remove redundant inc rc without instructions …
9051b51 
…between (noir-lang/noir#6183)

chore: reexport `CrateName` through `nargo` (noir-lang/noir#6177)
feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (noir-lang/noir#6168)
chore(docs): Add link to more info about proving backend to Solidity verifier page (noir-lang/noir#5754)
feat: let `Module::functions` and `Module::structs` return them in definition order (noir-lang/noir#6178)
chore: split `test_program`s into modules (noir-lang/noir#6101)
chore: remove `DefCollectorErrorKind::MacroError` (noir-lang/noir#6174)
feat(ssa): Simplify signed casts (noir-lang/noir#6166)
feat: visibility for modules (noir-lang/noir#6165)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 1, 2024
@AztecBot
feat(perf): Remove redundant inc rc without instructions between (noi…
83426fc 
…r-lang/noir#6183)

chore: reexport `CrateName` through `nargo` (noir-lang/noir#6177)
feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (noir-lang/noir#6168)
chore(docs): Add link to more info about proving backend to Solidity verifier page (noir-lang/noir#5754)
feat: let `Module::functions` and `Module::structs` return them in definition order (noir-lang/noir#6178)
chore: split `test_program`s into modules (noir-lang/noir#6101)
chore: remove `DefCollectorErrorKind::MacroError` (noir-lang/noir#6174)
feat(ssa): Simplify signed casts (noir-lang/noir#6166)
feat: visibility for modules (noir-lang/noir#6165)
TomAFrench added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 1, 2024
@AztecBot @TomAFrench
feat: Sync from noir (#8867)
2e6340b 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat(perf): Remove redundant inc rc without instructions between
(noir-lang/noir#6183)
chore: reexport `CrateName` through `nargo`
(noir-lang/noir#6177)
feat(perf): Remove inc_rc instructions for arrays which are never
mutably borrowed (noir-lang/noir#6168)
chore(docs): Add link to more info about proving backend to Solidity
verifier page (noir-lang/noir#5754)
feat: let `Module::functions` and `Module::structs` return them in
definition order (noir-lang/noir#6178)
chore: split `test_program`s into modules
(noir-lang/noir#6101)
chore: remove `DefCollectorErrorKind::MacroError`
(noir-lang/noir#6174)
feat(ssa): Simplify signed casts
(noir-lang/noir#6166)
feat: visibility for modules
(noir-lang/noir#6165)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <tom@tomfren.ch>
@AztecBot AztecBot mentioned this pull request Oct 1, 2024
Open
TomAFrench added a commit that referenced this pull request Oct 2, 2024
@TomAFrench
Merge branch 'master' into aztec-packages
fc2b3f3 
* master: (36 commits)
  fix: ignore compression of blocks after msg.len in sha256_var (#6206)
  feat(perf): Optimize array set from get (#6207)
  chore(refactor): Array set optimization context struct for analysis (#6204)
  fix: type variables by default should have Any kind (#6203)
  feat: remove orphaned blocks from cfg to improve `simplify_cfg` pass. (#6198)
  fix(ssa): Check if result of array set is used in value of another array set (#6197)
  fix(docs): Rename recursion.md to recursion.mdx (#6195)
  feat: skip `remove_enable_side_effects` pass on brillig functions (#6199)
  feat!: Syncing TypeVariableKind with Kind (#6094)
  feat(perf): Simplify the cfg after DIE (#6184)
  feat: refactor SSA passes to run on individual functions (#6072)
  chore: Remove macros_api module (#6190)
  fix: ensure to_bytes returns the canonical decomposition (#6084)
  chore: rename `DefinitionKind::GenericType` (#6182)
  feat(perf): Remove redundant inc rc without instructions between (#6183)
  chore: reexport `CrateName` through `nargo` (#6177)
  feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed (#6168)
  chore(docs): Add link to more info about proving backend to Solidity verifier page (#5754)
  feat: let `Module::functions` and `Module::structs` return them in definition order (#6178)
  chore: split `test_program`s into modules (#6101)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljklein michaeljklein michaeljklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @michaeljklein