chore: remove some _else_condition tech debt
#6522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
TomAFrench
commented
Nov 14, 2024
TomAFrench
force-pushed
the
tf/clean-up-else-conditions
branch
from
56fdd18
to
2d55b39
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
TomAFrench
added a commit
that referenced
this pull request
Nov 19, 2024
* master: (65 commits) chore: remove some `_else_condition` tech debt (#6522) chore: revert #6375 (#6552) feat: simplify constant MSM calls in SSA (#6547) chore(test): Remove duplicate brillig tests (#6523) chore: restructure `noirc_evaluator` crate (#6534) fix: take blackbox function outputs into account when merging expressions (#6532) chore: Add `Instruction::MakeArray` to SSA (#6071) feat(profiler): Reduce memory in Brillig execution flamegraph (#6538) chore: convert some tests to use SSA parser (#6543) chore(ci): bump mac github runner image to `macos-14` (#6545) chore(test): More descriptive labels in test matrix (#6542) chore: Remove unused methods from implicit numeric generics (#6541) fix: Fix poor handling of aliased references in flattening pass causing some values to be zeroed (#6434) fix: allow range checks to be performed within the comptime intepreter (#6514) fix: disallow `#[test]` on associated functions (#6449) chore(ssa): Skip array_set pass for Brillig functions (#6513) chore: Reverse ssa parser diff order (#6511) chore: Parse negatives in SSA parser (#6510) feat: avoid unnecessary ssa passes while loop unrolling (#6509) fix(tests): Use a file lock as well as a mutex to isolate tests cases (#6508) ...
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 19, 2024
feat(ssa): Unroll small loops in brillig (noir-lang/noir#6505) fix: Do a shallow follow_bindings before unification (noir-lang/noir#6558) chore: remove some `_else_condition` tech debt (noir-lang/noir#6522) chore: revert #6375 (noir-lang/noir#6552) feat: simplify constant MSM calls in SSA (noir-lang/noir#6547) chore(test): Remove duplicate brillig tests (noir-lang/noir#6523) chore: restructure `noirc_evaluator` crate (noir-lang/noir#6534) fix: take blackbox function outputs into account when merging expressions (noir-lang/noir#6532) chore: Add `Instruction::MakeArray` to SSA (noir-lang/noir#6071) feat(profiler): Reduce memory in Brillig execution flamegraph (noir-lang/noir#6538) chore: convert some tests to use SSA parser (noir-lang/noir#6543) chore(ci): bump mac github runner image to `macos-14` (noir-lang/noir#6545) chore(test): More descriptive labels in test matrix (noir-lang/noir#6542) chore: Remove unused methods from implicit numeric generics (noir-lang/noir#6541) fix: Fix poor handling of aliased references in flattening pass causing some values to be zeroed (noir-lang/noir#6434) fix: allow range checks to be performed within the comptime intepreter (noir-lang/noir#6514) fix: disallow `#[test]` on associated functions (noir-lang/noir#6449) chore(ssa): Skip array_set pass for Brillig functions (noir-lang/noir#6513) chore: Reverse ssa parser diff order (noir-lang/noir#6511) chore: Parse negatives in SSA parser (noir-lang/noir#6510) feat: avoid unnecessary ssa passes while loop unrolling (noir-lang/noir#6509) fix(tests): Use a file lock as well as a mutex to isolate tests cases (noir-lang/noir#6508) fix: set local_module before elaborating each trait (noir-lang/noir#6506) fix: parse Slice type in SSa (noir-lang/noir#6507) fix: perform arithmetic simplification through `CheckedCast` (noir-lang/noir#6502) feat: SSA parser (noir-lang/noir#6489) chore(test): Run test matrix on test_programs (noir-lang/noir#6429) chore(ci): fix cargo deny (noir-lang/noir#6501) feat: Deduplicate instructions across blocks (noir-lang/noir#6499) chore: move tests for arithmetic generics closer to the code (noir-lang/noir#6497) fix(docs): Fix broken links in oracles doc (noir-lang/noir#6488) fix: Treat all parameters as possible aliases of each other (noir-lang/noir#6477) chore: bump rust dependencies (noir-lang/noir#6482) feat: use a full `BlackBoxFunctionSolver` implementation when execution brillig during acirgen (noir-lang/noir#6481) chore(docs): Update How to Oracles (noir-lang/noir#5675) chore: Release Noir(0.38.0) (noir-lang/noir#6422) fix(ssa): Change array_set to not mutate slices coming from function inputs (noir-lang/noir#6463) chore: update example to show how to split public inputs in bash (noir-lang/noir#6472) fix: Discard optimisation that would change execution ordering or that is related to call outputs (noir-lang/noir#6461) chore: proptest for `canonicalize` on infix type expressions (noir-lang/noir#6269) fix: let formatter respect newlines between comments (noir-lang/noir#6458) fix: check infix expression is valid in program input (noir-lang/noir#6450) fix: don't crash on AsTraitPath with empty path (noir-lang/noir#6454) fix(tests): Prevent EOF error while running test programs (noir-lang/noir#6455) fix(sea): mem2reg to treat block input references as alias (noir-lang/noir#6452) chore: revamp attributes (noir-lang/noir#6424) feat!: Always Check Arithmetic Generics at Monomorphization (noir-lang/noir#6329) chore: split path and import lookups (noir-lang/noir#6430) fix(ssa): Resolve value IDs in terminator before comparing to array (noir-lang/noir#6448) fix: right shift is not a regular division (noir-lang/noir#6400)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 20, 2024
chore: switch to 1.0.0-beta versioning (noir-lang/noir#6503) chore: Release Noir(0.39.0) (noir-lang/noir#6484) feat: Sync from aztec-packages (noir-lang/noir#6557) feat(ssa): Unroll small loops in brillig (noir-lang/noir#6505) fix: Do a shallow follow_bindings before unification (noir-lang/noir#6558) chore: remove some `_else_condition` tech debt (noir-lang/noir#6522) chore: revert #6375 (noir-lang/noir#6552) feat: simplify constant MSM calls in SSA (noir-lang/noir#6547) chore(test): Remove duplicate brillig tests (noir-lang/noir#6523) chore: restructure `noirc_evaluator` crate (noir-lang/noir#6534) fix: take blackbox function outputs into account when merging expressions (noir-lang/noir#6532) chore: Add `Instruction::MakeArray` to SSA (noir-lang/noir#6071) feat(profiler): Reduce memory in Brillig execution flamegraph (noir-lang/noir#6538) chore: convert some tests to use SSA parser (noir-lang/noir#6543) chore(ci): bump mac github runner image to `macos-14` (noir-lang/noir#6545) chore(test): More descriptive labels in test matrix (noir-lang/noir#6542) chore: Remove unused methods from implicit numeric generics (noir-lang/noir#6541) fix: Fix poor handling of aliased references in flattening pass causing some values to be zeroed (noir-lang/noir#6434) fix: allow range checks to be performed within the comptime intepreter (noir-lang/noir#6514) fix: disallow `#[test]` on associated functions (noir-lang/noir#6449) chore(ssa): Skip array_set pass for Brillig functions (noir-lang/noir#6513) chore: Reverse ssa parser diff order (noir-lang/noir#6511) chore: Parse negatives in SSA parser (noir-lang/noir#6510) feat: avoid unnecessary ssa passes while loop unrolling (noir-lang/noir#6509) fix(tests): Use a file lock as well as a mutex to isolate tests cases (noir-lang/noir#6508) fix: set local_module before elaborating each trait (noir-lang/noir#6506) fix: parse Slice type in SSa (noir-lang/noir#6507) fix: perform arithmetic simplification through `CheckedCast` (noir-lang/noir#6502) feat: SSA parser (noir-lang/noir#6489) chore(test): Run test matrix on test_programs (noir-lang/noir#6429) chore(ci): fix cargo deny (noir-lang/noir#6501) feat: Deduplicate instructions across blocks (noir-lang/noir#6499) chore: move tests for arithmetic generics closer to the code (noir-lang/noir#6497) fix(docs): Fix broken links in oracles doc (noir-lang/noir#6488) fix: Treat all parameters as possible aliases of each other (noir-lang/noir#6477) chore: bump rust dependencies (noir-lang/noir#6482) feat: use a full `BlackBoxFunctionSolver` implementation when execution brillig during acirgen (noir-lang/noir#6481) chore(docs): Update How to Oracles (noir-lang/noir#5675) chore: Release Noir(0.38.0) (noir-lang/noir#6422) fix(ssa): Change array_set to not mutate slices coming from function inputs (noir-lang/noir#6463) chore: update example to show how to split public inputs in bash (noir-lang/noir#6472) fix: Discard optimisation that would change execution ordering or that is related to call outputs (noir-lang/noir#6461) chore: proptest for `canonicalize` on infix type expressions (noir-lang/noir#6269) fix: let formatter respect newlines between comments (noir-lang/noir#6458) fix: check infix expression is valid in program input (noir-lang/noir#6450) fix: don't crash on AsTraitPath with empty path (noir-lang/noir#6454) fix(tests): Prevent EOF error while running test programs (noir-lang/noir#6455) fix(sea): mem2reg to treat block input references as alias (noir-lang/noir#6452) chore: revamp attributes (noir-lang/noir#6424) feat!: Always Check Arithmetic Generics at Monomorphization (noir-lang/noir#6329) chore: split path and import lookups (noir-lang/noir#6430) fix(ssa): Resolve value IDs in terminator before comparing to array (noir-lang/noir#6448) fix: right shift is not a regular division (noir-lang/noir#6400)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 20, 2024
chore: switch to 1.0.0-beta versioning (noir-lang/noir#6503) chore: Release Noir(0.39.0) (noir-lang/noir#6484) feat: Sync from aztec-packages (noir-lang/noir#6557) feat(ssa): Unroll small loops in brillig (noir-lang/noir#6505) fix: Do a shallow follow_bindings before unification (noir-lang/noir#6558) chore: remove some `_else_condition` tech debt (noir-lang/noir#6522) chore: revert #6375 (noir-lang/noir#6552) feat: simplify constant MSM calls in SSA (noir-lang/noir#6547) chore(test): Remove duplicate brillig tests (noir-lang/noir#6523) chore: restructure `noirc_evaluator` crate (noir-lang/noir#6534) fix: take blackbox function outputs into account when merging expressions (noir-lang/noir#6532) chore: Add `Instruction::MakeArray` to SSA (noir-lang/noir#6071) feat(profiler): Reduce memory in Brillig execution flamegraph (noir-lang/noir#6538) chore: convert some tests to use SSA parser (noir-lang/noir#6543) chore(ci): bump mac github runner image to `macos-14` (noir-lang/noir#6545) chore(test): More descriptive labels in test matrix (noir-lang/noir#6542) chore: Remove unused methods from implicit numeric generics (noir-lang/noir#6541) fix: Fix poor handling of aliased references in flattening pass causing some values to be zeroed (noir-lang/noir#6434) fix: allow range checks to be performed within the comptime intepreter (noir-lang/noir#6514) fix: disallow `#[test]` on associated functions (noir-lang/noir#6449) chore(ssa): Skip array_set pass for Brillig functions (noir-lang/noir#6513) chore: Reverse ssa parser diff order (noir-lang/noir#6511) chore: Parse negatives in SSA parser (noir-lang/noir#6510) feat: avoid unnecessary ssa passes while loop unrolling (noir-lang/noir#6509) fix(tests): Use a file lock as well as a mutex to isolate tests cases (noir-lang/noir#6508) fix: set local_module before elaborating each trait (noir-lang/noir#6506) fix: parse Slice type in SSa (noir-lang/noir#6507) fix: perform arithmetic simplification through `CheckedCast` (noir-lang/noir#6502) feat: SSA parser (noir-lang/noir#6489) chore(test): Run test matrix on test_programs (noir-lang/noir#6429) chore(ci): fix cargo deny (noir-lang/noir#6501) feat: Deduplicate instructions across blocks (noir-lang/noir#6499) chore: move tests for arithmetic generics closer to the code (noir-lang/noir#6497) fix(docs): Fix broken links in oracles doc (noir-lang/noir#6488) fix: Treat all parameters as possible aliases of each other (noir-lang/noir#6477) chore: bump rust dependencies (noir-lang/noir#6482) feat: use a full `BlackBoxFunctionSolver` implementation when execution brillig during acirgen (noir-lang/noir#6481) chore(docs): Update How to Oracles (noir-lang/noir#5675) chore: Release Noir(0.38.0) (noir-lang/noir#6422) fix(ssa): Change array_set to not mutate slices coming from function inputs (noir-lang/noir#6463) chore: update example to show how to split public inputs in bash (noir-lang/noir#6472) fix: Discard optimisation that would change execution ordering or that is related to call outputs (noir-lang/noir#6461) chore: proptest for `canonicalize` on infix type expressions (noir-lang/noir#6269) fix: let formatter respect newlines between comments (noir-lang/noir#6458) fix: check infix expression is valid in program input (noir-lang/noir#6450) fix: don't crash on AsTraitPath with empty path (noir-lang/noir#6454) fix(tests): Prevent EOF error while running test programs (noir-lang/noir#6455) fix(sea): mem2reg to treat block input references as alias (noir-lang/noir#6452) chore: revamp attributes (noir-lang/noir#6424) feat!: Always Check Arithmetic Generics at Monomorphization (noir-lang/noir#6329) chore: split path and import lookups (noir-lang/noir#6430) fix(ssa): Resolve value IDs in terminator before comparing to array (noir-lang/noir#6448) fix: right shift is not a regular division (noir-lang/noir#6400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of
else_conditioninInstruction::IfElse