feat(nargo)!: save program ABI alongside ACIR #922
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #897
Description
Summary of changes
Rather than serializing a
Circuit
into aacir
file, we now serialize aCompiledProgram
(Circuit
+Abi
) into ajson
file.We still make use of the custom serialisation method for
Circuit
however JSON doesn't store bytes directly so we end up with an array. We could fix this by just encoding the entire thing into bytes rather than using json atm (and allowing exporting a JSON ABI separately).An example output (for the
simple_shield
circuit) is shown below:Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Additional context