Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): WASM compilation w/ dependencies #953

Closed
wants to merge 6 commits into from

Conversation

kobyhallx
Copy link
Contributor

@kobyhallx kobyhallx commented Mar 6, 2023

Related issue(s)

#952 Allow compilation with dependencies from WASM, #888 (comment)

Resolves #952 Allow compilation with dependencies from WASM

Description

Allows to call compile with a set of dependencies as a second argument. Those dependencies will be later resolved from noir-lang/noir-source-resolver

Summary of changes

crates/wasm/src/lib.rs adds the additional argument which will be iterated over to resolves dependencies. It's equivalent to declaring it in project configuration.

Dependency additions / changes

noirc_driver is now required by wasm

Test additions / changes

N/A

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

crates/wasm/src/lib.rs Outdated Show resolved Hide resolved
crates/wasm/src/lib.rs Outdated Show resolved Hide resolved
crates/wasm/src/lib.rs Outdated Show resolved Hide resolved
crates/wasm/src/lib.rs Outdated Show resolved Hide resolved
crates/wasm/src/lib.rs Outdated Show resolved Hide resolved
kobyhallx and others added 4 commits March 7, 2023 07:18
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
@kobyhallx
Copy link
Contributor Author

Handled in separate one

@kobyhallx kobyhallx closed this Mar 8, 2023
@kobyhallx kobyhallx deleted the kh-wasm-compile-w-dependency branch March 8, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow compilation with dependencies from WASM
3 participants