Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start debug session when receiving nargo.debug.dap command #85

Merged

Conversation

anaPerezGhiglia
Copy link
Contributor

@anaPerezGhiglia anaPerezGhiglia commented Jul 10, 2024

Description

Start a debug session when the extension receives the nargo.debug.dap command

Summary*

Use the built in workbench.action.debug.start vscode command to start the debug session

Screen.Recording.2024-07-10.at.12.13.19.mov

Additional Context

This PR has its sibling in noir repo noir-lang/noir#5474

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@anaPerezGhiglia anaPerezGhiglia marked this pull request as ready for review July 10, 2024 18:56
github-merge-queue bot pushed a commit to noir-lang/noir that referenced this pull request Jul 15, 2024
# Description
Give more visibility to debugger

## Summary\*

- Add a new `Debug` codelens action to main functions
- Unhid the `debug` command from nargo_cli


https://github.com/noir-lang/vscode-noir/assets/13237343/6e83d28c-126a-41ff-a23b-bc7ce9a50ccb

## Additional Context

This PR has its sibling in vscode-noir repo noir-lang/vscode-noir#85

## Documentation\*

Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
github-merge-queue bot pushed a commit to noir-lang/noir that referenced this pull request Jul 15, 2024
# Description
Give more visibility to debugger

## Summary\*

- Add a new `Debug` codelens action to main functions
- Unhid the `debug` command from nargo_cli


https://github.com/noir-lang/vscode-noir/assets/13237343/6e83d28c-126a-41ff-a23b-bc7ce9a50ccb

## Additional Context

This PR has its sibling in vscode-noir repo noir-lang/vscode-noir#85

## Documentation\*

Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
github-merge-queue bot pushed a commit to noir-lang/noir that referenced this pull request Jul 15, 2024
# Description
Give more visibility to debugger

## Summary\*

- Add a new `Debug` codelens action to main functions
- Unhid the `debug` command from nargo_cli


https://github.com/noir-lang/vscode-noir/assets/13237343/6e83d28c-126a-41ff-a23b-bc7ce9a50ccb

## Additional Context

This PR has its sibling in vscode-noir repo noir-lang/vscode-noir#85

## Documentation\*

Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
github-merge-queue bot pushed a commit to noir-lang/noir that referenced this pull request Jul 15, 2024
# Description
Give more visibility to debugger

## Summary\*

- Add a new `Debug` codelens action to main functions
- Unhid the `debug` command from nargo_cli


https://github.com/noir-lang/vscode-noir/assets/13237343/6e83d28c-126a-41ff-a23b-bc7ce9a50ccb

## Additional Context

This PR has its sibling in vscode-noir repo noir-lang/vscode-noir#85

## Documentation\*

Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@vezenovm vezenovm merged commit aacc780 into noir-lang:master Aug 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants