Fix compilation errors w/ Ubuntu 23.10

+ some minor doc fixes
noironetworks · Oct 19, 2023 · b262d5f · b262d5f
1 parent b194065
commit b262d5f
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 6 deletions.
diff --git a/agent-ovs/lib/include/opflexagent/PrometheusManager.h b/agent-ovs/lib/include/opflexagent/PrometheusManager.h
@@ -510,7 +510,7 @@ class AgentPrometheusManager : private PrometheusManager {
      * Create MoDBCounts metric family if its not present.
      * Update MoDBCounts metric family if its already present
      *
-     * @param counts     contains total number of object counts
+     * @param pCounts    contains total number of object counts
      *                   in MoDB per object type
      */
     void addNUpdateMoDBCounts(shared_ptr<ModbCounts> pCounts);

diff --git a/agent-ovs/ovs/include/SpanRenderer.h b/agent-ovs/ovs/include/SpanRenderer.h
@@ -68,7 +68,6 @@ class SpanRenderer : public SpanListener,
     /**
      * deletes mirror session
      * @param[in] sessionName name of session
-     * @return true if success, false otherwise.
      */
     void deleteMirror(const string& sessionName);
 

diff --git a/agent-ovs/ovs/include/SwitchConnection.h b/agent-ovs/ovs/include/SwitchConnection.h
@@ -17,6 +17,7 @@
 #include <mutex>
 #include <chrono>
 #include <atomic>
+#include <string>
 
 
 struct vconn;

diff --git a/libopflex/engine/OpflexPEHandler.cpp b/libopflex/engine/OpflexPEHandler.cpp
@@ -155,7 +155,7 @@ void OpflexPEHandler::ready() {
               << "Handshake succeeded";
 
     setState(READY);
-    getProcessor()->connectionReady(getConnection());
+    getProcessor()->connectionReady(dynamic_cast<OpflexConnection*>(getConnection()));
 }
 
 static bool validateProxyAddress(const Value &val,

diff --git a/libopflex/engine/OpflexPool.cpp b/libopflex/engine/OpflexPool.cpp
@@ -408,7 +408,6 @@ size_t OpflexPool::sendToRole(OpflexMessage* message,
                            bool sync, const std::string& uri) {
     std::unique_ptr<OpflexMessage> messagep(message);
     if (!active) return 0;
-    std::vector<OpflexClientConnection*> conns;
 
     const std::lock_guard<std::recursive_mutex> lock(conn_mutex);
     auto it = roles.find(role);

diff --git a/libopflex/engine/include/opflex/engine/internal/OpflexHandler.h b/libopflex/engine/include/opflex/engine/internal/OpflexHandler.h
@@ -46,8 +46,6 @@ class OpflexHandler : public opflex::jsonrpc::JsonRpcHandler {
      */
     virtual ~OpflexHandler() {}
 
-    virtual OpflexConnection* getConnection() const { return (OpflexConnection*)conn; }
-
     // *************************
     // Protocol Message Handlers
     // *************************

diff --git a/libopflex/include/opflex/rpc/JsonRpcConnection.h b/libopflex/include/opflex/rpc/JsonRpcConnection.h
@@ -16,6 +16,7 @@
 #ifndef RPC_JSONRPCCONNECTION_H
 #define RPC_JSONRPCCONNECTION_H
 
+#include <list>
 #include <mutex>
 #include <boost/noncopyable.hpp>