Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mechanism via GitHub releases #299

Merged
merged 2 commits into from
May 29, 2022

Conversation

ZyanKLee
Copy link
Contributor

my first golang PR for this project - and ever 😄

I could not sufficiently test the UI part AND the actual updating, as I currently am not at my Linux machine. Feel free to report any issues in these regards - I will fix them later, when I'm on Linux again.

For my testing I added the -c option to the cli, just left it in - perhaps its useful to someone else?

closes #271

Phillip Stockmann added 2 commits May 27, 2022 14:53
I also implemented semver comparison of the release versions, to avoid getting apps downgraded by older releases on accident if something happens to latest release.
@ZyanKLee ZyanKLee self-assigned this May 27, 2022
@ZyanKLee ZyanKLee added the go Pull requests that update Go code label May 27, 2022
@ZyanKLee ZyanKLee added this to the v0.12.0 milestone May 27, 2022
@AXDOOMER
Copy link
Collaborator

Couldn't test it without commenting out most of func update(ctx *ntcontext) and other lines of code, so the most important part where it downloads the update and installs it remains untested.

Peek 2022-05-27 10-07
Tested on Ubuntu 22.04

@ZyanKLee ZyanKLee merged commit c16394e into master May 29, 2022
@ZyanKLee ZyanKLee deleted the 271-update-mechanism-via-github-releases branch July 12, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mechanism via github releases
2 participants