Add parent detection

[jojo2357]

Fixes #299

before & after. Proton mail has its children accounted for.

I've done three things:

• include parent pid in processdata
• iff the cgroup is org.gnome.Shell, lets try to lookup our parent before invariably being resolved to org.gnome.Shell
• Enabled short-circuiting of the last some for performance

I don't expect this to be the final revision, so opening as draft to encourage discussion

[nokyan]

Hi, thanks a lot for the PR!
So far I haven't found anything wrong with it, I've had no false detections when testing around. If you believe it's ready, we can merge it I think. :)

[jojo2357]

I worry only that the hardcoded "org.gnome.Shell" will not be useful on other desktop managers.

[jojo2357]

Interestingly, my use case appears to have disappeared as Proton Mail is using the correct cgroups now...

[nokyan]

Interestingly, my use case appears to have disappeared as Proton Mail is using the correct cgroups now...

That's interesting indeed. It's still a useful feature though, surely Proton Mail isn't the only app affected by this.

I worry only that the hardcoded "org.gnome.Shell" will not be useful on other desktop managers.

I think that's okay for now as it doesn't harm Resources on other DEs. I'd export "org.gnome.Shell" into an array to make it easier to extend later. I've got a commit ready, I'd push it to your branch if that's okay with you.

[jojo2357]

Go ahead, Im waiting for #305 anyway

[jojo2357]

Side-by-side, current flatpak vers is identical to this PR. the other app, dolphin-emu seems to have figured itself out (when I move the .desktop to a location resources can read)

[nokyan]

Do you think this is ready for merging?

[jojo2357]

Im not confident to merge this until I can produce a solid example of this working.

I think I will have to design my own app to do it.

[jojo2357]

I found a reason, this time with libreoffice

1.6:

This branch:

[jojo2357]

@nokyan do you see any other examples of this PR fixing any apps? if so, and youre fine with the changes, then im fine undrafting and merging.

[nokyan]

@nokyan do you see any other examples of this PR fixing any apps? if so, and youre fine with the changes, then im fine undrafting and merging.

I haven't yet found other apps that might benefit from this. Though I am fine with the changes and a tree view for Processes is on the roadmap at some point as well, so keeping track of a process' parent already is useful as well.

[jojo2357]

Ok, ill resolve the merge conflict when i get the chance and then unmark draft

[jojo2357]

Currently rr is committing crimes, and i made sure again that it works as advertised.

[nokyan]

Sorry, I kinda forgot about this PR 😅
Merged. :)