feat(ui): bottom nav #2205
Merged
feat(ui): bottom nav #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nolanlawson
commented
Nov 19, 2022
| @@ -14,6 +14,7 @@ const persistedState = { | |||
| currentRegisteredInstance: undefined, | |||
| // we disable scrollbars by default on iOS | |||
| disableCustomScrollbars: process.browser && /iP(?:hone|ad|od)/.test(navigator.userAgent), | |||
| bottomNav: false, | |||
There was a problem hiding this comment.
Considering turning this on for all phone users (iOS and Android), but seems really tricky to detect properly. Folks can just turn this on themselves if they like.
alice-werefox
pushed a commit
to alice-werefox/sema-werefox-cafe
that referenced
this pull request
Apr 3, 2023
Co-authored-by: Benny Powers <web@bennypowers.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2164 but with some tweaks on my side, and plus we're running the CI tests now because it's my branch.