feat: Allow image descriptions to be read automatically by screen readers without needing to expand media.

[jcsteh]

Fixes #2257.

[jcsteh]

It's not great that this duplicates code in StatusMediaAttachments, but I wasn't sure how I could get that info without some serious re-plumbing and I'm not quite experienced enough with this code base to pull that off.

[nolanlawson]

One way to avoid the duplication would be to pass sensitive in to StatusMediaAttachments. But It's not a big deal either way.

[nolanlawson]

So unfortunately it looks like there's an issue here. If there is a sensitive media, and you click the "show sensitive media" button, then the aria-label doesn't change. It permanently shows the status in "sensitive" mode.

Maybe this wouldn't matter much in practice, but it would matter if you e.g. are scrolling through the timeline, press the y button to show the sensitive media, and the aria-label doesn't change at all.

I think in order to get this to work, we would have to plumb from the StatusMediaAttachments back to the Status. It looks like I already have a store value called sensitivesShown that does this. I can look into this.

pinafore/src/routes/_components/status/StatusMediaAttachments.html

Lines 217 to 237 in a775bd9

	toggleSensitiveMedia (changeFocus) {
	const { uuid } = this.get()
	const { sensitivesShown } = this.store.get()
	sensitivesShown[uuid] = !sensitivesShown[uuid]
	this.store.set({ sensitivesShown })
	this.fire('recalculateHeight')
	// Only change focus for clicks, not for hotkeys. It's weird if, when the entire toot
	// is focused and you press "y", that the focus changes to the sensitive media button.
	if (changeFocus) {
	requestAnimationFrame(() => {
	const element = this.refs.hideSensitiveMedia || this.refs.showSensitiveMedia
	try {
	element.focus({ preventScroll: true })
	} catch (e) {
	console.error('ignored focus error', e)
	}
	})
	}
	return true
	},
	async showFirstMedia () {

[nolanlawson]

This should do it! 470cb15

[jcsteh]

Oops. I broke it. I'll look into it later.

[nolanlawson]

Thank you for fixing the test! ❤️