You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, if there are no handlers, the handling attempt is anyway done, and the messages are logged that all handlers (zero out of zero) have succeeded.
With this PR, Kopf does not even attempt doing the handling cycle, if there are no handlers for the current event/cause. This also eliminates the unnecessary logging for fake handling cycles.
Notes
This PR is part of a chain leading to the resuming handlers on operator restarts: #103 -> #104 -> #105.
Refactoring
For simplicity in the future, a little refactoring is also performed: all causes are grouped into the internal and user-facing causes.
Also, the handling stack is now one call shorter (the all-purpose execute() is bypassed):
Description
Currently, if there are no handlers, the handling attempt is anyway done, and the messages are logged that all handlers (zero out of zero) have succeeded.
With this PR, Kopf does not even attempt doing the handling cycle, if there are no handlers for the current event/cause. This also eliminates the unnecessary logging for fake handling cycles.
Notes
This PR is part of a chain leading to the resuming handlers on operator restarts: #103 -> #104 -> #105.
Refactoring
For simplicity in the future, a little refactoring is also performed: all causes are grouped into the internal and user-facing causes.
Also, the handling stack is now one call shorter (the all-purpose
execute()
is bypassed):custom_object_handler→handle_cause→_execute→call_handler
custom_object_handler→handle_cause→execute→_execute→call_handler
Types of Changes
The text was updated successfully, but these errors were encountered: