Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Label sub-templates recursively #108

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed

[PR] Label sub-templates recursively #108

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive automation CI/CD: testing, linting, releasing automatically enhancement New feature or request

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-06-12 11:46:47+00:00
Original URL: zalando-incubator/kopf#108
Merged by nolar at 2019-06-13 16:14:02+00:00

Issue : #107, indirectly #13

Now, it is a bit easier to label both the created object (e.g. jobs) and its sub-templates (e.g. pods in jobs):

kopf.label(job, {'parent-name': name}, nested=['spec.template'])

Also, few tests added on the utility functions used internally, just to be sure they work as expected.

The auto-guessing on which sub-fields are templates, which are not (as suggested in #107) is skipped for now — that might require enumerating the kinds&fields from the docs.

Types of Changes

  • New feature (non-breaking change which adds functionality)
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Label sub-templates recursively Aug 19, 2020
@kopf-archiver kopf-archiver bot added automation CI/CD: testing, linting, releasing automatically enhancement New feature or request labels Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive automation CI/CD: testing, linting, releasing automatically enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

0 participants