-
Notifications
You must be signed in to change notification settings - Fork 88
Conversation
🤖 zincr found 0 problems , 0 warnings
|
🤖 zincr found 1 problem , 0 warnings
Details on how to resolve are provided below ApprovalsAll proposed changes must be reviewed by project maintainers before they can be merged Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.
|
1 similar comment
🤖 zincr found 1 problem , 0 warnings
Details on how to resolve are provided below ApprovalsAll proposed changes must be reviewed by project maintainers before they can be merged Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.
|
pass | ||
elif isinstance(objs, collections.abc.Iterable): | ||
for obj in objs: | ||
yield from walk(obj, nested=nested) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must be the first time I see recursion in "real" code!
Now, it is a bit easier to label both the created object (e.g. jobs) and its sub-templates (e.g. pods in jobs):
Also, few tests added on the utility functions used internally, just to be sure they work as expected.
The auto-guessing on which sub-fields are templates, which are not (as suggested in #107) is skipped for now — that might require enumerating the kinds&fields from the docs.
Types of Changes