Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Fix the newly added test with old checks #132

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed

[PR] Fix the newly added test with old checks #132

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive automation CI/CD: testing, linting, releasing automatically bug Something isn't working

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-07-03 16:28:24+00:00
Original URL: zalando-incubator/kopf#132
Merged by nolar at 2019-07-03 18:10:59+00:00

Issue : #24

Description

Few cross-PR bugs were introduced to the tests (and tests only):

#118 added a new test, and it was broken with the modified master. The merge, however, had no conflicts. The framework's code is not broken and functions properly, as expected. It is only one test.

#126 added a new e2e test, which expected the deletion logs, which never appeared, as they were removed in #118 (no more deletion events if there are no deletion handlers).

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Fix the newly added test with old checks Aug 19, 2020
@kopf-archiver kopf-archiver bot added automation CI/CD: testing, linting, releasing automatically bug Something isn't working labels Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive automation CI/CD: testing, linting, releasing automatically bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants