Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] [272] Enforce the version of coverage manually (pip fails to resolve) #274

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
Labels
archive automation CI/CD: testing, linting, releasing automatically

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-12-16 13:56:18+00:00
Original URL: zalando-incubator/kopf#274
Merged by nolar at 2019-12-16 14:07:31+00:00

Resolve coveralls vs. pytest-cov battle for coverage versions due to coverage==5.0 release 2 days ago.

Issue : closes #272
Affected: #258

Description

coverage==5.0 has been release on 14.12.2019 (2 days ago). This broke the CI/CD, as pip cannot resolve the version conflict:

  • pytest-cov wants coverage>=4.4, and is executed first.
  • coverage==5.0 is found and installed.
  • coveralls wants coverage<5.0, but it is too late to reinstall.

The fix is to install coverage<5.0 before any of the dependencies request it. The solution is temporary by its nature. See #273 for a more generic approach (version pinning and auto-upgrading) — will be done somewhen later.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] [272] Enforce the version of coverage manually (pip fails to resolve) Aug 19, 2020
@kopf-archiver kopf-archiver bot added the automation CI/CD: testing, linting, releasing automatically label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

No branches or pull requests

0 participants