Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

[272] Enforce the version of coverage manually (pip fails to resolve) #274

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Dec 16, 2019

Resolve coveralls vs. pytest-cov battle for coverage versions due to coverage==5.0 release 2 days ago.

Issue : closes #272
Affected: #258

Description

coverage==5.0 has been release on 14.12.2019 (2 days ago). This broke the CI/CD, as pip cannot resolve the version conflict:

  • pytest-cov wants coverage>=4.4, and is executed first.
  • coverage==5.0 is found and installed.
  • coveralls wants coverage<5.0, but it is too late to reinstall.

The fix is to install coverage<5.0 before any of the dependencies request it. The solution is temporary by its nature. See #273 for a more generic approach (version pinning and auto-upgrading) — will be done somewhen later.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Dec 16, 2019
@zincr
Copy link

zincr bot commented Dec 16, 2019

🤖 zincr found 0 problems , 1 warning

ℹ️ Dependency Licensing
✅ Large Commits
✅ Approvals
✅ Specification

Details on how to resolve are provided below


Dependency Licensing

All dependencies specified in package manager files must be reviewed, banned dependency licenses will block the merge, all new dependencies introduced in this pull request will give a warning, but not block the merge

Please ensure that only dependencies with licenses compatible with the license of this project is included in the pull request.

  • ℹ️ Could not process requirements.txt for new dependencies
     

@zincr
Copy link

zincr bot commented Dec 16, 2019

🤖 zincr found 1 problem , 1 warning

❌ Approvals
ℹ️ Dependency Licensing
✅ Large Commits
✅ Specification

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

Dependency Licensing

All dependencies specified in package manager files must be reviewed, banned dependency licenses will block the merge, all new dependencies introduced in this pull request will give a warning, but not block the merge

Please ensure that only dependencies with licenses compatible with the license of this project is included in the pull request.

  • ℹ️ Could not process requirements.txt for new dependencies
     

@nolar nolar merged commit a3d6d5b into zalando-incubator:master Dec 16, 2019
@nolar nolar deleted the 272-coverage-pinning branch December 16, 2019 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/CD broken with Coverage 5.0
2 participants