Fix unexpected (unused but passed) kwargs to peering routines #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error is: ``` TypeError: process_peering_event() got an unexpected keyword argument 'resource_indexed' ``` The kwarg is added in 1.30.0 for indexing, added as unused to all processing routines except the peering, and this was not caught in testing (both in automated and manual) — because the kwargs are unused and the peering is usually disabled in tests to not produce unnecessary logs/steps. Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
nolar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is:
The kwarg is added in 1.30.0 for indexing, added as unused to all processing routines except the peering, and this was not caught in testing (both in automated and manual) — because the kwargs are unused and the peering is usually disabled in tests to not produce unnecessary logs/steps.
Only affects the operator when the peering is enabled — either explicitly or auto-detected — i.e. when the peering CRDs & CRs are present. Non-peered operators are not affected.
Fixes #710