Restore specific groups for peering selectors #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
nolar
force-pushed
the
specific-peering-groups
branch
from
d7580e7
to
d6f21c2
Compare
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #644, Kopf's peering selectors were generalised only to "any name", with groups/versions removed — in order to satisfy both old (
zalando.org) and new (kopf.dev) groups of the CRD.This caused Kopf to scan all(!) groups to discover resources, not only the specific ones, which caused some issues in some cluster setups, e.g. where
metrics.k8s.ioAPI group is "503 Unavailable" because the extension is scaled down to zero (#740 #738). There is no strong reason to scan all available resources indeed. More on that, that is an unnoticed side-effect with extra work done by the operator.This PR restores the specific groups of the peering resources (and versions — because versions were there too, originally). But makes it so that BOTH old & new groups are supported. In practice, usually, only one of two groups will exist. If both groups exist, both peering resources will be served in parallel.
Fixes #740.
TODOs: