Decouple & isolate handling from specialised causes & handlers #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
This breaks the dependency of the "handling" routines to the specialised causes & handlers types. Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
This includes everything that makes "handling" pure and isolated from the rest of the framework. Specialised handlers and causes are defined and used elsewhere, though they remain based on the protocols defined in the base classes. Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
nolar
force-pushed
the
refactor-handler-execution
branch
from
d8b88ee
to
7924793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to make "handling" fully isolated so that it could be moved to the lower levels of the reactor/core.
For this, rudimentary base classes (almost interfaces) are extracted from causes, handlers, and states — while the specialised modules extend them as needed: e.g. states are needed only in read-only mode for handling, while the actual states are capable of producing derived/modified states.
More details can be found in separate commits.