Fall back to rudimentary login handlers if the clients are absent #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolar
force-pushed
the
rudimentary-logins
branch
2 times, most recently
from
1dca7fd
to
5e2c007
Compare
Positional args are not used, and positional args are not a protocol for handlers anymore. They were originally added to match the callback signatures when invocation had positional args (when filters/lifecycles were called via the invocation routines) — but this is not the case anymore. So, remove them. Keep only the kwargs. Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
This will make Kopf runnable in the majority of cases even with no `pykube-ng` and `kubernetes` client libraries installed. This was not a problem till recently, but then `pykube-ng` was removed from the implicit dependencies, so users get frustrated by "unauthenticated" or "ran out of credentials" errors. To avoid running too many login handlers at startup, the rudimentary login handlers are added strictly when the client libraries are absent, not always. This can be overridden with custom login handlers calling these functions (as documented). Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make Kopf runnable in the majority of cases even with no
pykube-ngandkubernetesclient libraries installed. This was not a problem till recently, but thenpykube-ngwas removed from the implicit dependencies (#655), so users get frustrated by "unauthenticated" or "ran out of credentials" errors (#349 #187, partially solved in #770).Two extra functions are added to the public interface:
kopf.login_with_kubeconfig()kopf.login_with_service_account()They can only read the rudimentary (but usually sufficient) data and pass them to the API requests "as is", with no post-processing or interpretation (or token rotation, or whatever the client libraries can provide).
To avoid running too many login handlers at startup, the rudimentary login handlers are added strictly when the client libraries are absent, not always. This can be overridden with custom login handlers calling these functions (as documented).
TODOs: