Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): Fix name of parameter #965

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

mboutet
Copy link
Contributor

@mboutet mboutet commented Oct 18, 2022

The name of the parameter in the doc for kopf.on.validate does not match the code. This PR updates the doc to match the code.

kopf/kopf/on.py

Line 158 in fb10a44

persistent: Optional[bool] = None,

@mboutet mboutet requested a review from nolar as a code owner October 18, 2022 23:56
@mboutet mboutet force-pushed the mboutet-patch-1 branch 2 times, most recently from 0eef56b to 26414dd Compare October 19, 2022 00:04
https://github.com/nolar/kopf/blob/fb10a44f5a5f6e5c458c4973c51395383303a8d6/kopf/on.py#L158

Signed-off-by: Maxence Boutet <maxenceboutet@outlook.com>
Signed-off-by: Maxence Boutet <mboutet@drw.com>
@nolar nolar merged commit 1d1f7b9 into nolar:main Oct 19, 2022
@nolar
Copy link
Owner

nolar commented Oct 19, 2022

Thanks for the fix!

@mboutet mboutet deleted the mboutet-patch-1 branch October 19, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants