Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(git changelog): resolve contributors' GitHub profile URL #294

Merged
merged 2 commits into from
Aug 4, 2024
Merged

feat(git changelog): resolve contributors' GitHub profile URL #294

merged 2 commits into from
Aug 4, 2024

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Aug 3, 2024

  • Resolve GitHub profile URL based on a contributor's GitHub no-reply email
  • Document how contributor information is resolved

nekomeowww
nekomeowww approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 3, 2024

✅ Successfully deployed to Netlify

Platform Status URL
Ubuntu Success https://66ae79aa43ec4dc2f1f6f64d--nolebase-integrations.netlify.app
Windows Success https://66ae79b4882592cd466a872d--nolebase-integrations.netlify.app

@nekomeowww nekomeowww merged commit 4dad600 into nolebase:main Aug 4, 2024
6 checks passed
@northword northword mentioned this pull request Aug 4, 2024
Merged
@northword
Copy link
Member

@giladgd I have made some changes based on this PR, please see #295 , comments and suggestions are welcome.

@giladgd giladgd deleted the profilePictureImprovements branch August 6, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@northword northword northword approved these changes

@nekomeowww nekomeowww nekomeowww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgd @northword @nekomeowww