Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style of InlineLinkPreview.vue #298

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2024

@nekomeowww
Copy link
Member

Sorry that I was late here to reply.
And, hi! Thank you for contributing, and welcome to Nolebase community!

May I ask one question? Is the "external link icon" a new feature that introduced by VitePress?

Theoretically, this shouldn't be removed directly, since the InlineLinkPreview isn't just simply adding an "external icon" for the links, but rather dynamically.

By dynamically I mean, if the link is not set to inline preview-able, then an "external icon" will be added to help the user to understand whether the link is "external" or not.

If removed, this feature will be broken. I don't think this is a right way to fix this.

@northword
Copy link
Member

yes,external link icon now is a vitepress's build-in feature. https://vitepress.dev/reference/default-theme-config#externallinkicon

@ghost
Copy link
Author

ghost commented Aug 21, 2024

@nekomeowww Sorry for the late reply. In this pull request, I erased the style of the arrow, because this is not needed anymore. Now VitePress-theme sets an inline arrow dynamically when you write a link to other websites and the option themeConfig.externalLinkIcon: true is written in config.js.

@nekomeowww
Copy link
Member

Thanks for explaining. I understand it now.

@nekomeowww nekomeowww enabled auto-merge (squash) August 22, 2024 00:40
@nekomeowww nekomeowww merged commit 8ce387b into nolebase:main Aug 22, 2024
6 checks passed
Copy link

✅ Successfully deployed to Netlify

Platform Status URL
Ubuntu Success https://66c68ad0466d47c0591e32fd--nolebase-integrations.netlify.app
Windows Success https://66c68adc4bcb5eaca450429d--nolebase-integrations.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants