7761: Fixed elementIsChildOf returning false for nested web components #7762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s; added .mjs files to prettier job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #7761.
I basically had to write my own implementation of the standard
element.contains()method inelementIsChildOffunction. This implementation takes into account shadow roots and slots, which are commonly used in web components. The standard implementation does not.I tested the solution in my own project and it fixes the issue. I have also tested it in the provided demos, it didn't seem to break anything.
Also, I've noticed that .mjs files are not included into the prettier job, so I added them and re-ran it.