Skip to content

Issues: noloman/MoneyTransactions

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 Open 8 Closed
5 Open 8 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Having mapping as extension functions means you can't mock the mapping when testing the classes that use the mapper. Therefore it might be nicer to make a separate mapper class enhancement New feature or request
#8 opened Oct 8, 2019 by noloman
@noloman
Somewhat strange package structure, data models and ui models inside data package enhancement New feature or request
#6 opened Oct 8, 2019 by noloman
@noloman
Click listener could just be set in the onCreateViewHolder instead of onBindViewHolder. Since the click listener will only pass through a transaction (which indeed should be updated every time in onBindViewHolder). enhancement New feature or request
#5 opened Oct 8, 2019 by noloman
@noloman
The code is not easily readable. There are a lot of lambdas inside lambdas going on which makes it harder to understand what's happening enhancement New feature or request
#2 opened Oct 8, 2019 by noloman
@noloman
The data model is still exposed to the ui by mapping it inside the ViewModel enhancement New feature or request
#1 opened Oct 8, 2019 by noloman
@noloman
ProTip! Add no:assignee to see everything that’s not assigned.