Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve validation result and generate json path #103

Merged
merged 34 commits into from
Feb 8, 2024
Merged

feat: Improve validation result and generate json path #103

merged 34 commits into from
Feb 8, 2024

Conversation

LoisSotoLopez
Copy link
Contributor

No description provided.

LoisSotoLopez and others added 30 commits January 11, 2024 15:12
@LoisSotoLopez
feat: Return function name on validation error
a170025
@LoisSotoLopez
wip: Use JSON Path function names & describe error
8abeaba
@LoisSotoLopez
wip: Makes validation err triple a tuple
5806fb9
@LoisSotoLopez
wip: Improves paths & required error
9042c2e
@LoisSotoLopez
wip: Pass tests & improve eval. conditions error
606b069
@LoisSotoLopez
wip: Make 25 & 26 tests pass
114309d
@LoisSotoLopez
wip: Remove all_of from paths
2f4d728
@LoisSotoLopez
wip: Fix string, number and object options
e592c98
@LoisSotoLopez
feat: Redesign error messages & cleanup code
00b6e4e
@LoisSotoLopez
feat: Remove unnecessary lists:flatten
40fbe6c
@LoisSotoLopez
feat: Use evaluated io invented word evalue
d95aca5
@LoisSotoLopez
feat: Add copyright header
b380a8d
@LoisSotoLopez
chore: Move internal function to proper section
4236188
@LoisSotoLopez
chore: Make gradualizer pass
db7ebd9
@LoisSotoLopez
feat: Return proper message on unique items
ea01371
@LoisSotoLopez
chore: Handle unique items error & cleanup code
2689123
@LoisSotoLopez
experiment: Remove diferentiation between OTP vers
ab947ab
@LoisSotoLopez
experiment: Make evaluate_conditions specs clearer
bcb21dd
@LoisSotoLopez
experiment: Change function_co... to fa_co...
9a3f5f0
@LoisSotoLopez
chore: remove last [report] from ndto calls
8dbb4fd
@LoisSotoLopez
experiment: Use proper error msg on false schema
4b9320a
@LoisSotoLopez
experiment: Rename some utils functions
3ee9c7e
@LoisSotoLopez
chore: Simplify ndto_utils & chain_conditions
a4c4101
@LoisSotoLopez
chore: Reorganize utils to remove functions
25cf707
@LoisSotoLopez
chore: Rewrite ndto_utils:find & find_value
39c2d18
@LoisSotoLopez
chore: Reorganize ndto_utils functions
f68b239
@LoisSotoLopez
chore: Type funct. names as functions for gradual.
e0e118c 
Type function names as functions for gradualizer to pass
@javiergarea
chore: some simplifications and styles
97fa7a8
@javiergarea
fix: forgot to add the new module to stage
30bd1a5
@LoisSotoLopez
chore: Rename FunPieces & simplify chain conds.
7dc1340
@LoisSotoLopez LoisSotoLopez added the enhancement New feature or request label Feb 8, 2024
@LoisSotoLopez LoisSotoLopez self-assigned this Feb 8, 2024
javiergarea
javiergarea reviewed Feb 8, 2024
View reviewed changes
test/ndto_SUITE.erl Outdated Show resolved Hide resolved
@LoisSotoLopez LoisSotoLopez mentioned this pull request Feb 8, 2024
Closed
@LoisSotoLopez @javiergarea
Update test/ndto_SUITE.erl
8390469 
Co-authored-by: Javier Garea <javigarea@gmail.com>
javiergarea
javiergarea reviewed Feb 8, 2024
View reviewed changes
test/ndto_SUITE.erl Outdated Show resolved Hide resolved
javiergarea
javiergarea reviewed Feb 8, 2024
View reviewed changes
src/ndto_generator.erl Outdated Show resolved Hide resolved
src/ndto_generator.erl Outdated Show resolved Hide resolved
src/ndto_generator.erl Outdated Show resolved Hide resolved
src/ndto_generator.erl Outdated Show resolved Hide resolved
javiergarea
javiergarea reviewed Feb 8, 2024
View reviewed changes
test/ndto_SUITE.erl Outdated Show resolved Hide resolved
@LoisSotoLopez @javiergarea
Update test/ndto_SUITE.erl
544fb7b 
Co-authored-by: Javier Garea <javigarea@gmail.com>
javiergarea
javiergarea approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@javiergarea javiergarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@javiergarea javiergarea merged commit fc36b9a into develop Feb 8, 2024
1 check passed
@javiergarea javiergarea deleted the feat/improve-validation-result-and-generate-json-path branch February 8, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiergarea javiergarea javiergarea approved these changes

Assignees

@LoisSotoLopez LoisSotoLopez

Labels
enhancement New feature or request
Projects
erf
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoisSotoLopez @javiergarea