Gas report #104
Gas report #104
Conversation
| bytes32 slot = keccak256(bytes("vulcan.ctx.gasReport.name")); | ||
| accounts.setStorage(address(vulcan.hevm), slot, b32Name); | ||
| bytes32 valueSlot = keccak256(abi.encodePacked("vulcan.ctx.gasReport", b32Name)); | ||
| accounts.setStorage(address(vulcan.hevm), valueSlot, bytes32(gasleft())); |
There was a problem hiding this comment.
ooc do these operations affect gasleft calculation? I assume gasleft() is computed first on this line, then put in storage, so I'm wondering if this storage operation would be the first gas consumed in this report?
(I am totally fine with this for the purposes of #103 but just curious!)
| for (uint256 i = 0; i < 5; i++) { | ||
| new MockTarget(); | ||
| } | ||
| ctx.endGasReport(); |
There was a problem hiding this comment.
re: above, I'd be curious to see a similar measurement done without the context methods to see how they compare gas-wise (to determine if and how much gas is added by the gas reporting calls themselves), e.g.
uint256 startGas = gasleft();
for (uint256 i = 0; i < 5; i++) {
new MockTarget();
}
println("gas used:", startGas - gasleft());There was a problem hiding this comment.
sorry for the delay, we are in the middle of an audit right now, but will definitely look into this next week
There was a problem hiding this comment.
Hey @holic . This is the gas comparison between the vulcan method vs using gasleft
| test/_modules/Context.t.sol:GasReport contract | | | | | |
|------------------------------------------------|-----------------|--------|--------|--------|---------|
| Deployment Cost | Deployment Size | | | | |
| 488124 | 2470 | | | | |
| Function Name | min | avg | median | max | # calls |
| nativeReport | 305575 | 305575 | 305575 | 305575 | 1 |
| vulcanReport | 313671 | 313671 | 313671 | 313671 | 1 |
And these are the measurements:
- Vulcan:
304141 - Native:
303650
This is the contract we used to compare
contract GasReport {
function vulcanReport() public {
ctx.startGasReport("test");
for (uint256 i = 0; i < 5; i++) {
new MockTarget();
}
ctx.endGasReport();
}
function nativeReport() public {
uint256 start = gasleft();
for (uint256 i = 0; i < 5; i++) {
new MockTarget();
}
println(string.concat("gas(test)", strings.toString(start - gasleft())));
}
}
|
Did ya'll have a chance to revisit this? |
No description provided.