Skip to content

Commit

Permalink
Use assigned MIDI SysEx ID
Browse files Browse the repository at this point in the history
  • Loading branch information
KlausStrohhaecker committed Mar 29, 2021
1 parent eae95b5 commit b65e5a6
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions firmware/src/shared/midi/nl_devctl_defs.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@

#include <stdint.h>

// three-byte MIDI Manufacturer ID (inofficial, selected to avoid conflicts with taken IDs
// three-byte MIDI Manufacturer ID
// see https://www.midi.org/specifications-old/item/manufacturer-id-numbers
#define MMID0 (0)
#warning TODO: use assigned number when they arrive
#define MMID1 (0x4E) // 'N', will likely become 0x20 or 0x21 with an official ID (0x20++ = european group)
#define MMID2 (0x4C) // 'L', will become the next free number assigned for us by midi.org
#define MMID1 (0x21)
#define MMID2 (0x58)

#define DEVICEID (0x01) // only 0x01 == MIDI Bridge, currently
#define MSGTYPE1 (0x44) // 'D', D.evice
Expand All @@ -21,7 +20,6 @@
#define CMD_LED_TEST_H (0x01) // ... for all colors (also for alignment during assembly
#define CMD_LED_TEST ((CMD_LED_TEST_H << 8) | CMD_LED_TEST_L)

// Note: we are using the non-official MIDI Manufacturer ID 0x00 0x4E 0x4C (ascii 'NL')
// The ID is mandatory after each 0xF0 sysex start so that other devices will
// ignore the sysex properly in case it actually reaches the device. This can happen
// for example in the fw-uploader which issues an INFO request before it continue
Expand Down

0 comments on commit b65e5a6

Please sign in to comment.