This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
F/new channel methods #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods for archive channel, join channel, create channel, set channel purpose and set channel topic.
Create, join, archive, set purpose and set topic for channels
|
@Workshop2 ready for your review. |
Workshop2
suggested changes
Oct 16, 2017
| /// Opens a DM channel to a user. Required to PM someone. | ||
| /// </summary> | ||
| Task<SlackChatHub> JoinDirectMessageChannel(string user); | ||
|
|
||
| /// <summary> | ||
| /// Creates a channel. |
| Task<SlackChatHub> JoinChannel(string channelName); | ||
|
|
||
| /// <summary> | ||
| /// Joins a channel. |
|
|
||
| // when | ||
| var result = true; | ||
| try |
There was a problem hiding this comment.
Should let exceptions bubble up and be caught by the test harness
|
@Workshop2 corrections made. |
|
Thanks @AshleyPoole Fantastic work |
|
Are you able to publish the nuget package for the latest version @Workshop2? I've checked nuget just but it's showing the old previous version. |
|
Done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to:
All new methods have accompanying tests using the format setup already in this repo.
This PR implements the feature request in issue (feature request) #11.