Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Color Brightness #60

Closed
arcticicestudio opened this issue May 11, 2019 · 0 comments
Closed

Comment Color Brightness #60

arcticicestudio opened this issue May 11, 2019 · 0 comments
Labels
context-config context-syntax priority-high scope-ux type-improvement
Milestone
0.10.0

Comments

@arcticicestudio
Copy link
Contributor

Bound to nordtheme/nord#94

This issue will implement the increase of the comment color (nord3) brightness by 10% from a lightness level of ~35% to ~45%.

➜ Please see nordtheme/nord#94 for all details about this design change decision.

⚠️ NOTE: This will also deprecate the „Custom Comment Contrast“ configuration because it is not necessary anymore for users to increase the brightness on their own.
A deprecation warning will be added to notify all users who have set a custom value for the configuration variable.
@arcticicestudio arcticicestudio added this to the 0.10.0 milestone May 11, 2019
@arcticicestudio arcticicestudio self-assigned this May 11, 2019
arcticicestudio added a commit that referenced this issue May 12, 2019
@arcticicestudio
Deprecate "Custom Comment Contrast" setting with warning notification
0be34cc 
Removed the logic for the theme setting and added logic to show a
deprecation notification when the user has set a value larger than 0.
Also removed the Less CSS styles to adapt to the configured value.

GH-60
arcticicestudio added a commit that referenced this issue May 12, 2019
@arcticicestudio
Comment Color Brightness
09333c3 
-> Please see nordtheme/nord#94 for all
   details about this design change decision.

Increased the comment color (`nord3`) brightness by 10% from a lightness
level of ~35% to ~45%.

This change also deprecates the "Custom Comment Contrast" theme setting.
It is not necessary anymore for users to increase the brightness on
their own when the default color has been increased by default.
A deprecation warning will be shown to notify all users who have set a
custom value for the configuration variable.

GH-60
@arcticicestudio arcticicestudio mentioned this issue May 12, 2019
Merged
@arcticicestudio arcticicestudio removed their assignment May 12, 2019
@arcticicestudio arcticicestudio mentioned this issue May 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-config context-syntax priority-high scope-ux type-improvement
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@arcticicestudio