Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Color Brightness #10

Closed
arcticicestudio opened this issue May 11, 2019 · 0 comments · Fixed by #11
Closed

Comment Color Brightness #10

arcticicestudio opened this issue May 11, 2019 · 0 comments · Fixed by #11
Labels
context-syntax priority-high scope-ux type-improvement
Milestone
0.2.0

Comments

@arcticicestudio
Copy link
Contributor

Bound to nordtheme/nord#94

This issue will implement the increase of the comment color (nord3) brightness by 10% from a lightness level of ~35% to ~45%.

➜ Please see nordtheme/nord#94 for all details about this design change decision.
@arcticicestudio arcticicestudio added this to the 0.2.0 milestone May 11, 2019
@arcticicestudio arcticicestudio self-assigned this May 11, 2019
arcticicestudio added a commit that referenced this issue May 11, 2019
@arcticicestudio
Add brightened nord3 color
4a8c50c 
The value is calculated using the Sass `lighten` (1) function to ensure
full interoperability with other port projects that providing this
theme feature.

References:
  (1) https://sass-lang.com/documentation/functions/color#lighten

GH-10
arcticicestudio added a commit that referenced this issue May 11, 2019
@arcticicestudio
Comment Color Brightness
8a96fc2 
-> Please see nordtheme/nord#94 for all
   details about this design change decision.

Increased the comment color (`nord3`) brightness by 10% from a lightness
level of ~35% to ~45%.

GH-10
@arcticicestudio arcticicestudio mentioned this issue May 11, 2019
Merged
@arcticicestudio arcticicestudio removed their assignment May 11, 2019
@arcticicestudio arcticicestudio mentioned this issue May 11, 2019
Open
arcticicestudio added a commit that referenced this issue Dec 20, 2019
@arcticicestudio
Add brightened nord3 color
d04b710 
The value is calculated using the Sass `lighten` (1) function to ensure
full interoperability with other port projects that providing this
theme feature.

References:
  (1) https://sass-lang.com/documentation/functions/color#lighten

GH-10
arcticicestudio added a commit that referenced this issue Dec 20, 2019
@arcticicestudio
Comment Color Brightness
0e8435b 
-> Please see nordtheme/nord#94 for all
   details about this design change decision.

Increased the comment color (`nord3`) brightness by 10% from a lightness
level of ~35% to ~45%.

GH-10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-syntax priority-high scope-ux type-improvement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Comment Color Brightness nordtheme/highlightjs
1 participant
@arcticicestudio