Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad coloring for haskell syntax #104

Closed
vabatta opened this issue Mar 4, 2018 · 1 comment · Fixed by #150
Closed

Bad coloring for haskell syntax #104

vabatta opened this issue Mar 4, 2018 · 1 comment · Fixed by #150
Labels
context-plugin context-syntax scope-compatibility type-feature
Milestone
version-0.11.0

Comments

@vabatta
Copy link

vabatta commented Mar 4, 2018

Hi, I started using the haskell syntax theme available at https://github.com/neovimhaskell/haskell-vim and in conjunction with this theme the colors of all the keywords are of the same color. Any fix?
@vabatta vabatta changed the title Bad coloring for some syntaxes Bad coloring for haskell syntax Mar 4, 2018
@arcticicestudio arcticicestudio added the hacktoberfest This repository participates in the Hacktoberfest label Oct 1, 2018
@arcticicestudio arcticicestudio self-assigned this Apr 13, 2019
@arcticicestudio arcticicestudio removed hacktoberfest This repository participates in the Hacktoberfest status-reproduction labels Apr 13, 2019
@arcticicestudio arcticicestudio added this to the 0.11.0 milestone Apr 13, 2019
arcticicestudio added a commit that referenced this issue Apr 13, 2019
@arcticicestudio
Haskell Syntax Plugin Support
a23e959 
Added support for Haskell syntax through the
neovimhaskell/haskell-vim (1) plugin.
This includes better coloring for types/classes using `nord7` instead of
highlighting them like keywords (`nord9`) and pre-processor and pragma
elements are now colorized correctly with `nord10`.

References:
  (1) https://github.com/neovimhaskell/haskell-vim

GH-104
@arcticicestudio arcticicestudio mentioned this issue Apr 13, 2019
Merged
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Apr 13, 2019 •
edited
Loading

Hi @vabatta 👋
Thanks for your contribution 👍

It's more a feature than a "fix" since the plugin uses specific syntax color groups that need to be implemented for the theme. I've submitted #150 that adds support for the plugin to improve the highlighting for Haskell.
Also make sure to correctly configure the plugin that allows to customize the syntax highlighting.

arcticicestudio added a commit that referenced this issue Apr 15, 2019
@arcticicestudio
Merge pull request #150 from arcticicestudio/feature/gh-104-haskell-s…
b0ffc6b 
…yntax-support

Haskell Syntax Plugin Support
@arcticicestudio arcticicestudio removed their assignment Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-plugin context-syntax scope-compatibility type-feature
Projects
None yet
Milestone
version-0.11.0
Development

Successfully merging a pull request may close this issue.

Haskell Syntax Plugin Support nordtheme/vim
2 participants
@vabatta @arcticicestudio