Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Color Brightness #146

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Comment Color Brightness #146

merged 2 commits into from
Mar 21, 2019

Conversation

arcticicestudio
Copy link
Contributor

@arcticicestudio arcticicestudio commented Mar 21, 2019 •
edited
Loading

Resolves #145

Before

gh-146-before
gh-145-before-2

After

gh-146-preview
gh-145-preview-2

@arcticicestudio
Update copyright notices and contributor metadata
096ff7b 
GH-145
@arcticicestudio
Comment Color Brightness
def9d75 
-> Please see nordtheme/nord#94 for all
   details about this design change decision.

Increased the comment color (`nord3`) brightness by 10% from a lightness
level of ~35% to ~45%.

This change also deprecates the comment contrast (1) configuration.
It is not necessary anymore for users to increase the brightness on
their own when the default color has been increased by default.
A deprecation warning will be shown to notify all users who have set a
custom value for the `g:nord_comment_brightness` configuration variable.

References:
  (1)  https://github.com/arcticicestudio/nord-vim#comment-contrast

GH-145
@arcticicestudio arcticicestudio added this to the 0.10.0 milestone Mar 21, 2019
@arcticicestudio arcticicestudio self-assigned this Mar 21, 2019
@arcticicestudio arcticicestudio merged commit 9e0249c into develop Mar 21, 2019
@arcticicestudio arcticicestudio deleted the improvement/gh-145-comment-color-brightness branch March 21, 2019 12:57
@arcticicestudio arcticicestudio removed their assignment Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-config context-syntax priority-high scope-ux type-improvement
Projects
None yet
Milestone
version-0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @svengreb