Make Error and MoreMsg highlight group consistent between console and gui modes. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @xulongwu4 👋, thanks for your contribution 👍
I've added some review comments in order to clarify the reason behind these changes since I'm currently not sure if they're all scoped to compatibility.
Co-Authored-By: Arctic Ice Studio <development@arcticicestudio.com>
svengreb
approved these changes
Apr 28, 2020
arcticicestudio
approved these changes
Apr 28, 2020
arcticicestudio
added
context-ui
scope-ux
and removed
status-pending
status-requires-info
labels
Error HighlightingBefore
After
“More“ HighlightingBefore
After
|
arcticicestudio
added a commit
that referenced
this pull request
Jun 16, 2020
…sole and GUI modes. (#202) Consistent `Error` and `MoreMsg` highligh. in term and GUI mode (#202) Before the `Error` group in GUI mode used `nord0` as foreground color instead of `nord4` resulting in a bad contrast. Also after checking ( links to it) Also since there was also no color defined for terminal mode for the `MoreMsg` group (see `:help MoreMsg` that link to `:help more-prompt`) Vim used the default color which was some kind of green. To ensure it matches Nord's style it has now been changed to use `nord8` (main accent color) for both terminal and GUI mode. This can be tested by running `:echon "MESSAGE\n"` taht produces a lot of lines that won't fit on the current screen space anymore. Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de>
defr0std
added a commit
to defr0std/nord-vim
that referenced
this pull request
May 17, 2021
* adds coc error gutter support * remove duplicated entries * Update colors/nord.vim Co-Authored-By: Arctic Ice Studio <development@arcticicestudio.com> * Fix typo line 13 * Uniform status lines config for bundled airline and lightline themes (nordtheme#169) The included theme bundles have not supported the "uniform status line" feature (nordthemeGH-58), which allows to change the background color of the status bar (StatusLine) group to `nord3`. Related to nordthemeGH-58 Resolves nordthemeGH-168 * Plugin support for `vim-startify` (nordtheme#176) Added custom highlight groups of the `vim-startify` (1) plugin to adapt to Nord's style. References: (1) https://github.com/mhinz/vim-startify Resolves nordthemeGH-159 * Remove underline from gutter line numbers (nordtheme#185) Vim version 8.1.2029 [1] added the `underline` attribute for the `CursorLineNr` group to `cterm` [2] based on vim/vim#4933 [3]. This change resulted in gutter line numbers being underlined which has now been reverted back to Nord's style by explicitly setting the attribute for the group to `NONE`. [1]: https://github.com/vim/vim/releases/tag/v8.1.2029 [2]: vim/vim@d9b0d83...017ba07#diff-80fffb3e9c20e93e5b2328a9a20e19c9 [3]: vim/vim#4933 Resolves nordthemeGH-174 * Prepare release version 0.13.0 * adds coc error gutter support * Add nvim-lsp support (nordtheme#198) Added highlighting support for the build-in Neovim language server [1] using the coc.nvim [2] groups as reference. [1]: https://github.com/neovim/nvim-lsp [2]: https://github.com/neoclide/coc.nvim * Consistent `Error` and MoreMsg highlight group consistent between console and GUI modes. (nordtheme#202) Consistent `Error` and `MoreMsg` highligh. in term and GUI mode (nordtheme#202) Before the `Error` group in GUI mode used `nord0` as foreground color instead of `nord4` resulting in a bad contrast. Also after checking ( links to it) Also since there was also no color defined for terminal mode for the `MoreMsg` group (see `:help MoreMsg` that link to `:help more-prompt`) Vim used the default color which was some kind of green. To ensure it matches Nord's style it has now been changed to use `nord8` (main accent color) for both terminal and GUI mode. This can be tested by running `:echon "MESSAGE\n"` taht produces a lot of lines that won't fit on the current screen space anymore. Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de> * Use transparent background for gutter line number in GUI mode (nordtheme#204) The `LineNr` and `CursorLineNr` highlight groups now have a transparent background in GUI mode. Before it was set to `nord0_gui` which worked fine in most cases. However, some plugins use these highlight groups to render their content in a popup window which can potentially have a different background color. This caused some issues e.g. for the fuzzy search plugin LeaderF [1]. The compatibility with the `g:nord_cursor_line_number_background` theme configuration has been verified to work as expected in both modes when it is set to `0` or `1`. This change is not related to the terminal mode or when using `set notermguicolors` since `ctermbg` for `LineNr` and `CursorLineNr` is set to `NONE` by default. [1]: https://github.com/Yggdroot/LeaderF * Release version 0.14.0 * adds coc error gutter support * Add nvim-lsp support (nordtheme#198) Added highlighting support for the build-in Neovim language server [1] using the coc.nvim [2] groups as reference. [1]: https://github.com/neovim/nvim-lsp [2]: https://github.com/neoclide/coc.nvim * Add basic TypeScript and improve TSX support (nordtheme#208) Basic highlighting support for TypeScript & TSX Added basic support to highlight TypeScript & TSX syntax more consistently through the HerringtonDarkholme/yats.vim plugin [1]. This includes improvements to highlight... 1. ...TypeScript interface an class names using `nord7` as foreground, where interfaces also use the bold attribute, to match with structs/classes. 2. ...global methods like e.g. `setTimeout` with `nord8` using the italic attribute to mark it kind of static. 3. ...regular expressions with `nord13` as foreground color instead of the normal color for quoted strings (`nord14`) to make it easier to differ between both. 4. ...global objects like `Error`, `JSON` and `console` with `nord7`. 5. ...primitive/builtin types like `string` with `nord9`. 6. ...TypeScript type references with `nord7`. 7. ...TypeScript specific characters like for type annotations (`:`) and member optionality (`?`) as operator with `nord9`. This also includes improvements for "vanilla" JavaScript elements. [1]: https://github.com/HerringtonDarkholme/yats.vim Resolves nordthemeGH-208 Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de> * Add support for vim-clap (nordtheme#178) Added basic support for vim-clap [1], a modern and performant generic finder and dispatcher for Vim and NeoVim. [1]: https://github.com/liuchengxu/vim-clap nordthemeGH-178 Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de> * Release version 0.15.0 Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: john.hennessey <john.hennessey@ef.com> Co-authored-by: John Hennessey <jghennes@gmail.com> Co-authored-by: Radu Vasilescu <vasilescur@gmail.com> Co-authored-by: Jose M. Murinello <jm.murinello@gmail.com> Co-authored-by: Alexander Jeurissen <1220084+alexanderjeurissen@users.noreply.github.com> Co-authored-by: xulongwu4 <xulongwu4@gmail.com> Co-authored-by: Sven Greb <development@svengreb.de> Co-authored-by: iamdi <helloiamdi@gmail.com> Co-authored-by: Johan <meck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highlight colors for "Error" and "MoreMsg" groups are not consistent between console vim and gvim. This PR makes them consistent.