Improve php highlighting #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svengreb
approved these changes
Aug 13, 2020
arcticicestudio
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Hi @pirey 👋, thanks for your contribution 👍
That's a great improvement! For some reasons highlighting of functions/methods and structs/classes seem to be tricky when it comes to create regular expressions for Vim's parsing engine. I guess these groups must have been added after I've added the PHP groups since it bothered me that I could not match the style for some languages to the ones of other ports (like e.g. JetBrains IDEs or VS Code) due to this limitation.
Support for plugins are always welcome, but we should check which plugin comes with a good set of features and is maintained actively to ensure we don't have to maintain multiple ones.
Your changes make it able to easily differ classes and functions/methods from variables and syntactic characters like braces.
Will be shipped with the next minor release 🚢
arcticicestudio
added a commit
that referenced
this pull request
Jun 9, 2021
This is a follow up for #218 [1] which added highlighting groups for the bundled PHP syntax, but the groups are actually defined by the StanAngeloff/php.vim [2] plugin. Therefore the added highlighting calls will be moved to a plugin section. Additionally, the `phpClassExtends` and `phpClassImplements` groups have been added to improve the highlighting for classes that implement or extended interfaces/classes. The `phpUseClass` has also been added to improve the highlighting for imports. [1]: #218 [2]: https://github.com/StanAngeloff/php.vim Related to GH-218 GH-262 Co-authored-by: Sven Greb <development@svengreb.de>
arcticicestudio
added a commit
that referenced
this pull request
Jun 9, 2021
This is a follow up for #218 [1] which added highlighting groups for the bundled PHP syntax, but the groups are actually defined by the StanAngeloff/php.vim [2] plugin. Therefore the added highlighting calls will be moved to a plugin section. Additionally, the `phpClassExtends` and `phpClassImplements` groups have been added to improve the highlighting for classes that implement or extended interfaces/classes. The `phpUseClass` has also been added to improve the highlighting for imports. [1]: #218 [2]: https://github.com/StanAngeloff/php.vim Related to GH-218 Closes GH-262 Co-authored-by: Sven Greb <development@svengreb.de>
crispgm
pushed a commit
to crispgm/nord-vim
that referenced
this pull request
Jun 10, 2021
This is a follow up for nordtheme#218 [1] which added highlighting groups for the bundled PHP syntax, but the groups are actually defined by the StanAngeloff/php.vim [2] plugin. Therefore the added highlighting calls will be moved to a plugin section. Additionally, the `phpClassExtends` and `phpClassImplements` groups have been added to improve the highlighting for classes that implement or extended interfaces/classes. The `phpUseClass` has also been added to improve the highlighting for imports. [1]: nordtheme#218 [2]: https://github.com/StanAngeloff/php.vim Related to nordthemeGH-218 Closes nordthemeGH-262 Co-authored-by: Sven Greb <development@svengreb.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added highlight for some groups in php, to better match highlighting in vscode, because I think highlight in vscode is nice.
Here's the comparison before (left = neovim, right = vscode):
Here's the comparison after:
Still cannot highlight some element, e.g trait
use,$thiskeyword, because missing highlight group for those, probably need additional syntax definition plugin for php?