Add public API function to get Nord colors #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jandamm 👋, thanks for your contribution 👍 |
|
@arcticicestudio Any update? |
arcticicestudio
requested changes
Apr 29, 2021
There was a problem hiding this comment.
Thanks for your patience, the amount of tasks for Nord requires a lot of time.
I've reviewed and tested the function and it works great. Only left one review comment to ensure it is compatible with all colors.
Also please move the function to the bottom of the file and add the following header before it:
"+------------+
"+ Public API +
"+------------+
"+--- Functions ---+
arcticicestudio
added
status-pending
status-revision
and removed
status-requires-review
labels
Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
|
Sure thing. |
svengreb
approved these changes
May 2, 2021
arcticicestudio
changed the title
crispgm
pushed a commit
to crispgm/nord-vim
that referenced
this pull request
Jun 10, 2021
Implemented the `NordPalette` pubic API function that returns all Nord colors as dictionary. This allows to use the colors in other Vim scripts without the need to copy & paste the colors from the documentations or the Nord Vim theme sources. Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de> Closes nordthemeGH-224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way a user who wants to use the colors of the Nord theme without having to copy hex-codes from the website.
This way adding/modifying highlight groups could be done like this: