-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: wrong group name #252
Conversation
Typo in group names: `PMenuSel` -> `PmenuSel` `PMenu` -> `Pmenu`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kunzaatko 👋, thanks for your contribution 👍
Also thanks for your patience, the large amount of tasks for the Nord project are really time consuming and free time is kind of rare.
Looks good to me 👍🏻
I guess this mismatch was never really noticed because most of the time users rely on plugins like coc or vim-clap which come with custom highlighting groups and UI libraries.
I actually would not notice it either, if it were not for the neovim fork I was making. I have already written an e-mail to you about it, but I guess it must have disappeared in the flood of e-mails you are getting. Here it is nord.nvim. In the e-mail, I was asking whether you would maybe want to adopt it as a neovim fork, since the colour groups of neovim against vim are slowly diverging. It is an exact copy apart from it including the additional groups. |
Sorry for not replying, I've moved your email into the "queue" directory, but the time to process all of them is rare 😐 Anyway, I'll try to find some time this weekend to post a reply in all the issues & PRs regarding this topic and also finally implement support for TreeSitter. |
Fixed two typos in group names: - `PMenuSel` -> `PmenuSel` - `PMenu` -> `Pmenu` This mismatch was never really noticed because most of the time users rely on plugins like coc [1] or vim-clap [2] which come with custom highlighting groups and UI libraries. [1]: https://github.com/neoclide/coc.nvim [2]: https://github.com/liuchengxu/vim-clap Co-authored-by: Sven Greb <development@svengreb.de>
Typo in group names:
PMenuSel
->PmenuSel
PMenu
->Pmenu