Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Color Brightness #118

Merged

Conversation

arcticicestudio
Copy link
Contributor

Bound to nordtheme/nord#94
Resolves #117

This issue will implement the increase of the comment color (nord3) brightness by 10% from a lightness level of ~35% to ~45%.

➜ Please see nordtheme/nord#94 for all details about this design change decision.

Before

gh-146-before
gh-145-before-2

After

gh-146-preview
gh-145-preview-2

-> Please see nordtheme/nord#94 (1) for all
   details about this design change decision.

Increased the comment color (`nord3`) brightness by 10% from a lightness
level of ~35% to ~45%.

References:
  (1) nordtheme/nord#94

GH-117
@arcticicestudio arcticicestudio merged commit 7e3881b into develop Mar 25, 2019
@arcticicestudio arcticicestudio deleted the improvement/gh-117-comment-color-brightness branch March 25, 2019 12:32
@arcticicestudio arcticicestudio removed their assignment Mar 25, 2019
This was referenced Apr 3, 2019
arcticicestudio added a commit that referenced this pull request Jul 20, 2019
VS Code 1.36.0 (1) June 2019 introduced support for indent guide lines
in the tree view (2). To adapt to Nord's style and ensure it is still
distinguishable from the background when hovering with the mouse, the
new brightened comment color based on ` nord3` (GH-118) is used.

References:
  (1) https://code.visualstudio.com/updates/v1_36
  (2) https://code.visualstudio.com/updates/v1_36#_tree-indent-guides

GH-145
arcticicestudio added a commit that referenced this pull request Jul 20, 2019
VS Code 1.36.0 (1) June 2019 introduced support for indent guide lines
in the tree view (2). To adapt to Nord's style and ensure it is still
distinguishable from the background when hovering with the mouse, the
new brightened comment color based on ` nord3` (GH-118) is used.

References:
  (1) https://code.visualstudio.com/updates/v1_36
  (2) https://code.visualstudio.com/updates/v1_36#_tree-indent-guides

Resolves GH-145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants