Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add underline to links in markdown #71

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

octref
Copy link
Contributor

@octref octref commented May 31, 2018

While I was verifying this issue in VS Code: microsoft/vscode#50382,

I found Nord does not add a underline to links in Markdown. However, VS Code would underline markdown links. This causes inconsistency:

1

If you add the following setting:

  "editor.tokenColorCustomizations": {
    "textMateRules": [
      {
        "scope": "markup.underline.link",
        "settings": {
          "fontStyle": "underline"
        }
      }
    ]
  }

2

That is because VS Code's tokenizer is much faster than the linkifying in markdown, so as you are typing, the whole link is immediately recognized as markup.underline.link and given underline, and this glitch would disappear.

Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍

Sorry for the delay, I've had no free time (job 👨‍⚕️, study 📖, life 🏋️‍♂️ etc.) to work on my or any other :octocat: OSS project (see Tweets 🐦 from April and June), but from the beginning of July I finished my studies and can finally spend time on OSS again 💚

@arcticicestudio arcticicestudio merged commit 2895e63 into nordtheme:develop Jun 26, 2018
@octref
Copy link
Contributor Author

octref commented Jun 26, 2018

Thanks! Nord has been my favorite theme. You are really good at design and engineering - hard to believe you are still a student 😉

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jun 26, 2018

Thank you for the compliment 😉
I started early over almost ten years ago (wow, time flies) to teach myself everything about programming, design and computer science and absolutely wanted to do this as a job. Without lying, I can say that GitHub and the whole open source community are the source of my current knowledge and helped me to improve every day 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants