Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Retire on Removal.sol for direct retirement #733

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

amiecorso
Copy link
Contributor

@amiecorso amiecorso commented Mar 5, 2024

NO-3613

Repurposes migrate method on Removal contract to serve as direct retirement endpoint for certificate creation from arbitrary sets of removals

Copy link

swarmia bot commented Mar 5, 2024

Copy link

openzeppelin-code bot commented Mar 5, 2024

Implement Retire on Removal.sol for direct retirement

Generated at commit: e5f3d2128f840e3e9f9c5d9d5d21d44c3a5187ea

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
2
0
8
34
45
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
1
36
37

For more details view the full report in OpenZeppelin Code Inspector

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.1%. Comparing base (fd34ba0) to head (e5f3d21).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #733   +/-   ##
======================================
  Coverage    64.1%   64.1%           
======================================
  Files          14      14           
  Lines         980     980           
  Branches      152     152           
======================================
  Hits          629     629           
  Misses        292     292           
  Partials       59      59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amiecorso amiecorso enabled auto-merge (squash) March 7, 2024 21:31
@amiecorso amiecorso disabled auto-merge March 7, 2024 21:31
@amiecorso amiecorso merged commit 447f6fb into master Mar 7, 2024
8 of 9 checks passed
@amiecorso amiecorso deleted the amie-direct-retirement branch March 7, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants