-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public transfer endpoint for CONSIGNOR
to move tokens
#735
Conversation
Public transfer endpoint for
|
Severity Level | Results | |
---|---|---|
Contracts | Critical High Medium Low Note Total |
1 2 0 8 34 45 |
Dependencies | Critical High Medium Low Note Total |
0 0 0 1 36 37 |
For more details view the full report in OpenZeppelin Code Inspector
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
======================================
Coverage 67.8% 67.8%
======================================
Files 12 12
Lines 787 788 +1
Branches 130 130
======================================
+ Hits 534 535 +1
Misses 205 205
Partials 48 48 ☔ View full report in Codecov by Sentry. |
* - Respects the rules of `Removal._beforeTokenTransfer`. | ||
* - `ids` and `amounts` must have the same length. | ||
* - If `to` refers to a smart contract, it must implement {IERC1155Receiver-onERC1155BatchReceived} and return the | ||
* acceptance magic value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
The merge-base changed after approval.
NO-3614
I chose to make this a separate endpoint from the existing
safeBatchTransferFrom
because that calls the superclasssafeBatchTransferFrom
which does enforce that the sender is the owner or approved of the tokens (a limitation we need ourCONSIGNOR
to be exempt from)This separate endpoint 1) leaves the security of the original
safeBatchTransferFrom
intact and 2) makes it simpler to reason about permission and functionality.