Remove unused params on Removal.mintBatch
#738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #738 +/- ##
======================================
Coverage 67.8% 67.8%
======================================
Files 12 12
Lines 788 788
Branches 130 130
======================================
Hits 535 535
Misses 205 205
Partials 48 48 ☔ View full report in Codecov by Sentry. |
Remove unused params on
|
| Severity Level | Results | |
|---|---|---|
| Contracts | Critical High Medium Low Note Total |
1 2 0 8 34 45 |
| Dependencies | Critical High Medium Low Note Total |
0 0 0 1 36 37 |
For more details view the full report in OpenZeppelin Code Inspector
rlfarman
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an additional simplification we can gain in removing
RestrictedNORI, removes the params that were related toRestrictedNORIfunctionality fromRemoval.mintBatch.This is a breaking change that needs to be deployed at the same time that we do a corresponding release of our services with these updates. Will require a short period of time in which minting from the app isn't possible.