-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mumbai upgrade deployment 3-14-24 #739
Conversation
*/ | ||
mapping(uint256 => uint256) private _removalIdToProjectId; | ||
mapping(uint256 => uint8) private _projectIdToHoldbackPercentage; |
Check warning
Code scanning / Slither
Unused state variable Warning
@@ -143,7 +143,7 @@ | |||
* @notice Deprecated. Previously the address of the RestrictedNORI contract. | |||
* This storage gap remains to maintain the storage layout of the contract. | |||
*/ | |||
address private _storageGap; | |||
address private _restrictedNORI; |
Check warning
Code scanning / Slither
Unused state variable Warning
@@ -143,7 +143,7 @@ | |||
* @notice Deprecated. Previously the address of the RestrictedNORI contract. | |||
* This storage gap remains to maintain the storage layout of the contract. | |||
*/ | |||
address private _storageGap; | |||
address private _restrictedNORI; |
Check warning
Code scanning / Slither
State variables that could be declared constant Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
======================================
Coverage 68.0% 68.0%
======================================
Files 12 12
Lines 793 793
Branches 130 130
======================================
Hits 540 540
Misses 205 205
Partials 48 48 ☔ View full report in Codecov by Sentry. |
Mumbai upgrade deployment 3-14-24
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
First upgrade of 2024, artifacts, a little bit of readability improvement to configure-assets-after-deployment