Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mumbai upgrade deployment 3-14-24 #739

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Conversation

amiecorso
Copy link
Contributor

First upgrade of 2024, artifacts, a little bit of readability improvement to configure-assets-after-deployment

*/
mapping(uint256 => uint256) private _removalIdToProjectId;
mapping(uint256 => uint8) private _projectIdToHoldbackPercentage;

Check warning

Code scanning / Slither

Unused state variable Warning

@@ -143,7 +143,7 @@
* @notice Deprecated. Previously the address of the RestrictedNORI contract.
* This storage gap remains to maintain the storage layout of the contract.
*/
address private _storageGap;
address private _restrictedNORI;

Check warning

Code scanning / Slither

Unused state variable Warning

Market._restrictedNORI is never used in Market
@@ -143,7 +143,7 @@
* @notice Deprecated. Previously the address of the RestrictedNORI contract.
* This storage gap remains to maintain the storage layout of the contract.
*/
address private _storageGap;
address private _restrictedNORI;

Check warning

Code scanning / Slither

State variables that could be declared constant Warning

Market._restrictedNORI should be constant
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.0%. Comparing base (61a042c) to head (c665016).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #739   +/-   ##
======================================
  Coverage    68.0%   68.0%           
======================================
  Files          12      12           
  Lines         793     793           
  Branches      130     130           
======================================
  Hits          540     540           
  Misses        205     205           
  Partials       48      48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openzeppelin-code bot commented Mar 14, 2024

Mumbai upgrade deployment 3-14-24

Generated at commit: c66501665324fcb615883e8d82be0209e1b814dd

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
2
0
8
34
45
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
1
36
37

For more details view the full report in OpenZeppelin Code Inspector

@amiecorso amiecorso merged commit 1cc3b1d into master Mar 15, 2024
8 of 9 checks passed
@amiecorso amiecorso deleted the amie-mumbai-deployment-3-14-24 branch March 15, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants