fix: make portable seek_and_modify_string_in_file (mac OsX) #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
n2st::seek_and_modify_string_in_file
was not portable. MacOsx implementation ofsed
does not have a--in-place
flag. Refactor using-i
Checklist:
Code related
tests/README.md
for local testing procedure)commit_msg_reference.md
in the repository root for detailsPR creation related
base ref
branch is set to thedev
branch (the build-system won't be triggered otherwise)dev
branch (the build-system will reject it otherwise)PR description related
# <issue-id>
if changes are of typefix
Note for repository admins
Release PR related
push/merge
on the default branch (ie:main
) and therelease
branch.draft
mode until all the release reviewers are ready to push the release.release
->main
branch is created (not in draft mode), it triggers the build-system testmain
branch, it triggers the semantic-release automation