Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle Relative Path from Parent Call to run_bats_tests_in_docker.bash #80

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

RedLeader962
Copy link
Contributor

@RedLeader962 RedLeader962 commented Aug 6, 2024

Description

Summary:

  • The variable initialization for N2ST_VERSION has been migrated to a common script. This change aligns with the best coding practices of defining and initializing variables in a common area.
  • The TeamCity environment message logging sequence has been reorganized for better clarity and log tracking. (This addresses issue NMO-571)
  • Adds visual separators in the script for enhanced readability.

Checklist:

Code related

  • I have made corresponding changes to the documentation (i.e.: function/class, script header, README.md)
  • I have commented hard-to-understand code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes (Check tests/README.md for local testing procedure)
  • My commit messages follow the conventional commits specification. See commit_msg_reference.md in the repository root for details

PR creation related

  • My pull request base ref branch is set to the dev branch (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the dev branch (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix

Note for repository admins

Release PR related

  • Only repository admins have the privilege to push/merge on the default branch (ie: main) and the release branch.
  • Keep PR in draft mode until all the release reviewers are ready to push the release.
  • Once a PR from release -> main branch is created (not in draft mode), it triggers the build-system test
  • On merge to the main branch, it triggers the semantic-release automation

…r.bash

- Add visual separators for enhanced readability.
- Move variable initialization for N2ST_VERSION to a common script.
- Reorganize TeamCity environment message logging.

Issue NMO-571
[skip release]
@RedLeader962 RedLeader962 merged commit fd344c0 into dev Aug 6, 2024
1 check passed
RedLeader962 pushed a commit that referenced this pull request Aug 6, 2024
## [2.1.8](v2.1.7...v2.1.8) (2024-08-06)

### Bug Fixes

* handle relative path from parent call to run_bats_tests_in_docker.bash ([838b226](838b226))
* Handle Relative Path from Parent Call to run_bats_tests_in_docker.bash ([#80](#80)) ([fd344c0](fd344c0))
@RedLeader962
Copy link
Contributor Author

🎉 This issue has been resolved in version 2.1.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant