Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update to serialport v11 #160

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

alexrudd2
Copy link
Contributor

@alexrudd2 alexrudd2 commented Jul 4, 2023

Closes #142.

I believe there's an upstream bug with the TypeScript type signatures:
serialport/node-serialport#2651
As such, this only works if you modify node_modules(!) and I've marked it as draft.

Runs on actual hardware.

@alexrudd2
Copy link
Contributor Author

alexrudd2 commented Jul 4, 2023

Also, unclear exactly where 11.0.0 came from on NPM: serialport/node-serialport#2650 Fixed upstream by tagging on GitHub

@nornagon
Copy link
Owner

Thanks for all the dep updates :) should all be merged now, dropping a comment here as it's the last dep update still open.

@alexrudd2 alexrudd2 marked this pull request as ready for review October 3, 2023 17:50
@nornagon nornagon merged commit d28d2c3 into nornagon:main Oct 26, 2023
4 checks passed
@alexrudd2 alexrudd2 deleted the serialport-v11-origin branch October 26, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Upgrade to node-serialport v10 (or v11)
2 participants