Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up CI by avoiding double compile #169

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Speed up CI by avoiding double compile #169

merged 1 commit into from
Jul 12, 2023

Conversation

alexrudd2
Copy link
Contributor

@nornagon I recommend looking at this PR first. :)

Since npm ci already compiles the project, npm build is redundant. Dropping it saves ~30s, a 33% speedup.

Before:
Screenshot 2023-07-12 at 3 40 58 PM

After:
Screenshot 2023-07-12 at 3 41 15 PM

@alexrudd2 alexrudd2 changed the title Speed GitHub Actions by avoiding double compile Speed up CI by avoiding double compile Jul 12, 2023
@nornagon nornagon merged commit 33fbd4f into nornagon:main Jul 12, 2023
3 checks passed
@alexrudd2 alexrudd2 deleted the ci-speedup branch July 12, 2023 21:45
jedahan pushed a commit to jedahan/saxi that referenced this pull request Sep 1, 2023
@alexrudd2
ci: Avoid compiling twice (nornagon#169)
c5ebeba
@jedahan jedahan mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrudd2 @nornagon