Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @types/node to 14.x #170

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

alexrudd2
Copy link
Contributor

The @types/node package got out of sync with the tested versions of node.

Versions higher than 14 trigger type errors in express-server-static-core. (They have no practical runtime effect, but break tsc)

Error: node_modules/@types/express-serve-static-core/index.d.ts(471,18): 
error TS2430: Interface 'Response' incorrectly extends interface 
'ServerResponse<IncomingMessage>'.
  Property 'req' is optional in type 'Response' but required in type 
'ServerResponse<IncomingMessage>'.
Error: src/server.ts(18,11): error TS2769: No overload matches this call.
  The last overload gave the following error.
    Argument of type 'NextHandleFunction' is not assignable to parameter 
of type 'PathParams'.

I know you typically don't like package-lock.json updates but this one is so short I left it in.

@nornagon nornagon merged commit 5f5dcf3 into nornagon:main Jul 14, 2023
3 checks passed
@alexrudd2 alexrudd2 deleted the types-node-v14 branch July 14, 2023 23:11
jedahan pushed a commit to jedahan/saxi that referenced this pull request Sep 1, 2023
* chore(deps): update dependency @types/node to 14.x

* Specifiy minimum node version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants