Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mvp #9

Closed
wants to merge 73 commits into from
Closed

feat: mvp #9

wants to merge 73 commits into from

Conversation

norskeld
Copy link
Owner

@norskeld norskeld commented Aug 12, 2022 •
edited
Loading

This PR implements the MVP.

Things to not forget to implement:

  • Better error handling/reporting for actions, especially for fs actions.
  • Better error handling/reporting for parsing and validating manifest.
  • Add error reporting for parsing and validating remote repository string.
  • Missing sanity and safety checks.
    • Terminate on action failure.
    • Do not unpack into an existing destination.

Adding tests would be nice too.

Resolves #13
Resolves #15

@norskeld norskeld added the feat New feature or request label Aug 12, 2022
@norskeld norskeld self-assigned this Aug 12, 2022
@norskeld norskeld changed the title feat: wire up replacements and actions feat: mvp Dec 20, 2023
norskeld added 12 commits January 6, 2024 23:25
@norskeld
chore: update spec.kdl
870d281
@norskeld
refactor: rewrite basics according to new spec
1f87faf
@norskeld
refactor: apply clippy suggestions
17a3b4a
@norskeld
chore: add clippy.toml with MSRV specified
de0c7b3
@norskeld
refactor: remove unnecessary else blocks
c09115b
@norskeld
refactor: redesign cli and make it more shell-friendly
2bedfce 
I decided to switch to command-based design and get rid of `file:` prefix for
local repositories. This allows:

- Get rid of programmatic shell expansion and simply leverage shell
capabilities.
- Make use of proper tab completions since now there's no prefix that'd been
breaking such functionality, which was rather annoying.

Also refactored code a bit and slightly simplified/reorganized it.
@norskeld
chore: update spec.kdl
6f2d168
@norskeld
feat(executor): flesh out basic executor, implement echo actions
cc57f37
@norskeld
refactor: remove useless q-mark operators
e036155
@norskeld
refactor: remove useless let bindings and references
1ddfbed
@norskeld
chore: enable autocompletion inside format strings
9057162
@norskeld
refactor: apply clippy suggestions
f8abc76
norskeld added 17 commits March 10, 2024 12:05
@norskeld
refactor(clippy): allow variant names with the same prefix
2f0a98d
@norskeld
feat(app): bail if the destination path already exists
7148544
@norskeld
refactor: clean up and improve comments a bit
da3680a
@norskeld
refactor(app): use try_exists instead of exists
1e8f02b
@norskeld
refactor(actions): slightly simplify trait bounds for action executor…
e82a7a2 
…s, use `try_exists`
@norskeld
feat(executor): delete config file after scaffolding is done
51dfb94
@norskeld
refactor(config): derive Default instead of manual impl
e2c3ecb
@norskeld
refactor(actions): replace expect() with anyhow's Result
e64c50e
@norskeld
chore: update project description
0487ef6
@norskeld
refactor(spec): improve spec
146decf
@norskeld
refactor(actions): stylize unknown action message
311a1fd
@norskeld
refactor(config): refactor prompts parsing according to spec
fa90c6d
@norskeld
refactor(actions): adjust styling for suite names and prompts
e35f9d9
@norskeld
refactor(app): add info prints, adjust style a bit
ae05d31
@norskeld
feat: implement fancy error reporting via miette
e1b0ae9
@norskeld
refactor(unpacker): refactor error handling in tar unpacker
8a3e633
@norskeld
refactor(config): replace Error as IoError alias with qualified import
c6faf4a
@norskeld norskeld force-pushed the feat/replacements branch from 422a99b to c6faf4a Compare March 10, 2024 09:05
norskeld added 10 commits March 10, 2024 12:14
@norskeld
refactor: rename manifest to config
426d7d1 
Because `arx.kdl` is essentially a config file, and manifest has a different
meaning and purpose.
@norskeld
refactor(repository): refactor error handling in repository
5383454
@norskeld
feat(repository): implement fancy error reporting for parser
75c3721
@norskeld
refactor(repository): slightly improve error report for fetching repo…
14f296b 
…sitory
@norskeld
refactor(actions/prompts): move static helper methods from struct int…
60f29c9 
…o mod
@norskeld
refactor(config): do not parse default for select prompts
674f0bb
@norskeld
feat(prompts): implement number prompt, slightly restructure
51ff257
@norskeld
refactor(actions): remove artificial delay when performing replacements
8b3425d
@norskeld
refactor(config): slightly change error message
7fab26c
@norskeld
refactor(config): factor out parsing of inject nodes
536d998
@norskeld norskeld closed this Mar 10, 2024
@norskeld norskeld deleted the feat/replacements branch March 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@norskeld norskeld

Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: mvp feat: allow to use local repositories
1 participant
@norskeld