List Item Insert - negative indexing

[Durman]

Problem statement

It looks like a bug that -1 index does not refer to the last element.

#3827

[zeffii]

in the List Item Insert node, handles incoming data differently when list vs numpy.ndarray

[zeffii]

sverchok/nodes/list_struct/item_insert.py

Lines 107 to 110 in 94b5cf3

	for ind, i in zip(*params):
	if self.replace and len(data_out) > ind:
	data_out.pop(ind)
	data_out.insert(ind, i)

[Durman]

The approach is not efficient for replace mode. Should be data_out[ind] = i

[zeffii]

sverchok/nodes/list_struct/item_insert.py

Lines 107 to 112 in e1be475

	for ind, i in zip(*params):
	idx = ind % len(data) # translate to positive idx
	if self.replace:
	data_out[idx] = i
	else:
	data_out.insert(idx, i)

[Durman]

Or like this =). But this, I think, does not give big performance improvement, at least compare to moving from O(len(data)) to O(1).

if self.replace:
    for ind, i in zip(*params):
        idx = ind % len(data)  # translate to positive idx
        data_out[idx] = i
else:
    for ind, i in zip(*params):
        idx = ind % len(data)  # translate to positive idx
        data_out.insert(idx, i)

[zeffii]

hehe .. or that. commit if you wish :)

[Durman]

It seems another bug was produced by the fix. I guess next string is to blame

sverchok/nodes/list_struct/item_insert.py

Line 108 in 510c1e3

idx = ind % len(data) # translate to positive idx

[Durman]

7cb3450

[Durman]

The fix changes behavior in some cases. It seems that previous behavior is not valid in the example